From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 92C96444D2 for ; Thu, 13 Oct 2022 16:08:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD74668BD72; Thu, 13 Oct 2022 19:08:37 +0300 (EEST) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2027.outbound.protection.outlook.com [40.92.99.27]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8342168BAA3 for ; Thu, 13 Oct 2022 19:08:31 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ft+B2K2G856BDRUEsAFKkEhhP127bce1BGLAKZtrQnw8I+N9QQizkbpMjYcN3C764cCrGwkHMuxSkExySwQ7N90ZD3plI2ZV2lKWWq1FWS4MXYHuNZ0hlfQ8/Hhec90rEMMhyb4yvFN/G2fuV44Q0ZVhsF/9mdh1BcKRh7pjkG+w/hU5IDj14THdEg9V0HP7HYBdDHWgJndSbBpeGWb+CQtHDtmW2xBLDRfYxSpclF0j70yPIyaoh5uG9y00ncWmgVNUWlkAE8t48xffraXvBHZya++lJUFiuP1wl9m1y3rHzEaWSL59lMeTGoPpV3m2kfCPXlW1E74EyX60moEdVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mdoOJOaAZ4owUClOXGtAET1kpyIzj6dKfOmyFYmYCz0=; b=bKA0HW7kWku0eVlCSNazc8WeDy1Qg25hHiZQRBFWEtFZr4/9Uk+dy655JDThDxkIyg10TKnfHpnSC+vigKjxvFlMaMcWIiF/7jWwa5Q62fbM9i827S7M7RW9uY2v6O//21nXlHV4mwmOyxBOMADmNQEZoar1b0uK7R39IE+t5yRbCRaIScMZUrg17Kj8OP1XoNc8U0hETFFz8p5Q45FY4JXosD/BFvodOamducvTgraHABEz9ZtThC6XBXmC0l0czBjVe3e/bJexMTdXZFJbGrL0fWmv6gdbo/EuzZXnqwralLx2f2pElXgKs0Vc/Riu1uaNCXOmUDQX0wnT6Gyy3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mdoOJOaAZ4owUClOXGtAET1kpyIzj6dKfOmyFYmYCz0=; b=iVV5nSPDbSNuaWGuGwO9ZmuqL6IAKv7t2cxXoOfKc4uD7JIMIrCwWGs3hwxiVrVtu729EZnLsf8X5LGj8tn4voyTnD2wf5/CAxeU8xMs4AvjydspkLdgJn9QafuO/qrR46ZEEiM1/aX+YNwFYHmpRLlvjGHGBiDNVN/8mTrk4wrp6y5a+Td811BiyMAbY+niwXfiz9L4pOAOgnU6Gx3FwGoLX+mIvQEgKTk9mKloLpuleYEAnK1CM6lgot4fK8w50BYvssvtzOlGEVyJs+rw5jLd/v4sueihFP1j/amhuG2p0OHOs7c1wJkjq0ikUixd4foerZnPENtoUG3KNB1jpg== Received: from OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:186::5) by TYCP286MB2462.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:188::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct 2022 16:08:27 +0000 Received: from OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM ([fe80::5fa3:fb9a:f219:8c6f]) by OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM ([fe80::5fa3:fb9a:f219:8c6f%4]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022 16:08:27 +0000 From: Wu Jianhua To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding Thread-Index: AQHY3ikJgFdXkq4tME+m/9XuU1s84q4KmZUqgAGrKYCAACuYSoAADkGAgAAAYyA= Date: Thu, 13 Oct 2022 16:08:27 +0000 Message-ID: References: <58ed0f9c-5c1d-885a-ba12-c6a9afeefdf1@gmail.com> In-Reply-To: <58ed0f9c-5c1d-885a-ba12-c6a9afeefdf1@gmail.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [tbW8xFWFyH7gVsmH0mVpvP2UE2IUP+uD] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OSZP286MB2173:EE_|TYCP286MB2462:EE_ x-ms-office365-filtering-correlation-id: 64ab0c89-b0d1-46ae-2592-08daad352a08 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AgeN2YoKKl39nwE7BUB+wNrYl57vXYbaCiL7QxFzuB3n1dHct3WQKUxUnVCvdoQdgK++c3hxHJQllwAcrlj0obj+MjxrEXWavEtkTuAv5W/0uUyWrz0DYVPCEiqik1pVPo9kid334ERdXXScDXYcTM1nC+/7X4345LHtSwRFe1IubwQ4MHv37h2CLEO1B2lM1u+f/YVluYPpfNRqcfpGrxtGvMBOY1rICEIOqodQth3CvrpLU5O9FtWGKrgxNGiNGY+cTGblSHt/x7vvJZz+Qq10q2+Vsj93oSGUf4/Xndyf0nbnuX1AHjM7LqF4L8yuWaCyjDusTMcGYgcmcaAQk5YIjyU65vHZR13SFL+SwQXkd3Xqt9e1gZJnAAGLkMwnJPftO5EMhnx2kdN7WLqxq6tjdaBzTOhpPpLUqyMyIbMtE26oNGsmSM4fIRS15iaIQOsrsNmTYAAK1LwAKW5PJeoi1XuTQNTzRMjuEj3xwhooZrkU9MAYRO3egA6Xao3Mvy2dZZlbbPT1wD97KwoKR9qy8xp8hhUSVY0BS75y9v3E/52hRlHPVAJE+4RvaYsC8Y1GU/X6gxehevYvy472JRQREefquUNMgEB/fTqLbXXaANzokgt038BmKUZFYJlvKT32c4bRnzyi+/HKMdK2FdwW818Ta4PfEGsJ2Ok0d1LyAxMX1PdkCd7Lzphil/D7 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?mV17DiM507drihh9FQcXWidYQBS9Pg8Y8zuGiu1+cYgMGTUDp8ZYkvZn?= =?Windows-1252?Q?hnYHrTWTJ59DLorrJcAAkS5dXwF5sgns6WmHovIOpEg/hbS6qAmUh3Bo?= =?Windows-1252?Q?+D+98KBV+ib3Owr4eKJJvllYHxkNFkc8UnuI4+aHZvHpI4O1hrbE8dwZ?= =?Windows-1252?Q?HKDHHH+MFk+v+YJzOJb8lIei/8vY3vFpJKrb71BoDoer5VJmbzQx49lq?= =?Windows-1252?Q?/IQ6CZA51XzBXMcd/MwIIph3PoHaex2QIVTzjdd5/jkANNIyRdc4pwnE?= =?Windows-1252?Q?MeNUyU6nTE7IwZFU2BwBe6x4YSCio5JHDtz19grk904WGywqOvvVM8gx?= =?Windows-1252?Q?yLlbapt2etdV84n242pHEFJGncY4Oa5Q8D8qtZLSVDg+UzvMWl9gHfan?= =?Windows-1252?Q?lcIlyIXMbaCSBKeln5KUJZRG+AOFUHqsu8DgWBmuZ9u07Lq6Hb+6iyMh?= =?Windows-1252?Q?eWM+2RUgtA56G83JejSLtv4HWVj0qX4TwlQXBNMRVRkA/8qLMHehYO8c?= =?Windows-1252?Q?FMrfihKzHbrbxneq85eb0B0qHzV/I3Ays8C1YmIAMtJCjIFdlVW6Lhu1?= =?Windows-1252?Q?xGf59FVWlVUcGjR45LC4cuOqZ9loAyXRCWxawDG3KYwEhrk0z4M9++HU?= =?Windows-1252?Q?jLnUGr0MVDHsoWx+ilviVjr/ovoO43ZbubCqvR2u5XRd2D2yUGn2OCvY?= =?Windows-1252?Q?KjcSu2rdWqHsrxxI6cav9jqcjRO8zYXs1y8XcBFMw5JYzD+f9H31UZ1t?= =?Windows-1252?Q?YFKwi4Vyvj68Jintg/IttuvxGXrPz1V2HD9p89sU/iBf1zgIC++2dnWu?= =?Windows-1252?Q?sfJLCNJaR+Cg+NDvCgBb0kpLni4XJjDKLsY+KryWXN293VVcWB/+l1cm?= =?Windows-1252?Q?2fCsnJzqrdL3jU88h/KEUqpR23KhwnffQHGIAJjUI5qXhX6YhUplbfqL?= =?Windows-1252?Q?NhwoI64ajOBGIDn1wowDOwilHVY3gN0iJehv1Eu+cocOJMaut+t/nHfN?= =?Windows-1252?Q?xKWBccFDFFYW9maz5PLF8Ri1jPrD+g7j3YbI44/keix/pq1lulDXSNeD?= =?Windows-1252?Q?d+H1WuC1AeCbzUUITca3ATv+NO1sIZZYOlgG2Z6t09aWlHt/VAL1tgEN?= =?Windows-1252?Q?9N3/ozu+PVbRUMjst2TRkpzAEqj59VlS7e+0ChvVv+glv9XQiOUo7pc+?= =?Windows-1252?Q?CW957N94gkzzUggY35N2SRDHYG1pA4n1oImlLo+BaVDP/ix6fn7sNAiR?= =?Windows-1252?Q?yj8tmh+wmamDwGJwSVKwneRfDbWNhUXXfIdp82yK52Yx02MPj95CuVUW?= =?Windows-1252?Q?Yw3jFOVQgsu3Lr/fr3wlsT7/9b3uOjhGvbQNU6uzJwKotDbXdUPHntoO?= =?Windows-1252?Q?Ix94W6XUVcXhyA=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 64ab0c89-b0d1-46ae-2592-08daad352a08 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 16:08:27.6239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB2462 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer wrote: > On 10/13/2022 12:48 PM, Wu Jianhua wrote: >>> Lynne wrote: >> >>> Oct 12, 2022, 13:09 by toqsxw@outlook.com: >> >>>> [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and= AV1 decoding >>>> >>>> Patch attached. >>>> >> >>> The Sync locking functions and the queue locking functions should >>> be a function pointer in the device/frame context. Vulkan has >>> the same issue, and that's how I did it there. This allows for >>> API users to plug their own locking primitives in, which they need >>> to in case they initialize their own contexts. >> >> I don=92t need to follow your design. >> >>> You should also document which fields API users have to set >>> themselves if they plan to use their own context. >> >> Where should I document them? Doesn=92t the comments enough? >> >>> Also, struct names in the public context lack an AV prefix. >> Will fix. And which struct? Could you add the reference? >> >>> D3D12VA_MAX_SURFACES is a terrible hack. Vendors should >>> fix their own drivers rather than users running out of memory. >> >> Not my responsibility as a personal developer. I know nothing >> about the drivers. You can ask those vendors to fix them. I don=92t >> think it=92s a `terrible hack`. On my test, The MAX_SURFACES is >> enough for the decoder. If there are any docs or the drivers fixed >> it, just simply remove it. Why user will run out of memory? >> >>> Also, you have code style issues, don't wrap one-line if statements >>> or loops in brackets. >> Will fix. And which loop? Could you add the reference? >> >>> ff_d3d12dec_get_suitable_max_bitstream_size is an awful function. >>> It does float math for sizes and has a magic mult factor of 1.5. >>> You have to calculate this properly. >> It simply calculate the size of NV12 and P010. Will add comment. > > Then you should probably use imgutils.h functions for that, and/or > AVPixFmtDescriptor from pixdesc.h. Great! Really thanks for the details. I will try to take a look at how to d= o that better. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".