[FFmpeg-devel] 回复: [PATCH] avcodec/x86/vvc/vvcdsp_init: fix linking error when configuring with --disable-ssse3 --disable-optimizations options

[Wu Jianhua <toqsxw@outlook.com>]

> 发件人: Nuo Mi <nuomi2021@gmail.com>
> 发送时间: 2024年3月3日 6:49
> 收件人: FFmpeg development discussions and patches
> 抄送: Wu Jianhua
> 主题: Re: [FFmpeg-devel] [PATCH] avcodec/x86/vvc/vvcdsp_init: fix linking error when configuring with --disable-> > ssse3 --disable-optimizations options
> 
> Thank you, Jianhua.
> This patch mixes many things.
> Could you help split it into smaller, more atomic patches?
> For example, one for moving code blocks and another for fixing --disable-ssse3.
> 

Sure. I sent the v2.

>  #define AVG_INIT(bd, opt) do {                                          \
> -    c->inter.avg    = bf(avg, bd, opt);                                 \
> -    c->inter.w_avg  = bf(w_avg, bd, opt);                               \
> +    c->inter.avg    = bf(ff_vvc_avg, bd, opt);                          \
> +    c->inter.w_avg  = bf(ff_vvc_w_avg, bd, opt);                        \
> Why change the function scope to fix a compilation issue?

I use the same way that adds prototypes for the functions as HEVC DSP. Hence, the functions
cannot be declared with static and need the prefix to avoid naming conflict.



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".