Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes
@ 2024-04-15 17:35 toqsxw
  2024-04-17 13:14 ` Nuo Mi
  0 siblings, 1 reply; 4+ messages in thread
From: toqsxw @ 2024-04-15 17:35 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Wu Jianhua

From: Wu Jianhua <toqsxw@outlook.com>

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
---
 libavcodec/x86/vvc/vvcdsp_init.c | 35 +++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/libavcodec/x86/vvc/vvcdsp_init.c b/libavcodec/x86/vvc/vvcdsp_init.c
index 23a3172c45..d9203f4d5f 100644
--- a/libavcodec/x86/vvc/vvcdsp_init.c
+++ b/libavcodec/x86/vvc/vvcdsp_init.c
@@ -30,9 +30,42 @@
 #include "libavcodec/vvc/dsp.h"
 #include "libavcodec/x86/h26x/h2656dsp.h"
 
+#define PUT_PROTOTYPE(name, depth, opt) \
+void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const uint8_t *src, ptrdiff_t srcstride, int height, const int8_t *hf, const int8_t *vf, int width);
+
+#define PUT_PROTOTYPES(name, bitd, opt) \
+        PUT_PROTOTYPE(name##2,   bitd, opt) \
+        PUT_PROTOTYPE(name##4,   bitd, opt) \
+        PUT_PROTOTYPE(name##8,   bitd, opt) \
+        PUT_PROTOTYPE(name##12,  bitd, opt) \
+        PUT_PROTOTYPE(name##16,  bitd, opt) \
+        PUT_PROTOTYPE(name##24,  bitd, opt) \
+        PUT_PROTOTYPE(name##32,  bitd, opt) \
+        PUT_PROTOTYPE(name##48,  bitd, opt) \
+        PUT_PROTOTYPE(name##64,  bitd, opt) \
+        PUT_PROTOTYPE(name##128, bitd, opt)
+
+#define PUT_BPC_PROTOTYPES(name, opt) \
+    PUT_PROTOTYPES(name,  8, opt)     \
+    PUT_PROTOTYPES(name, 10, opt)     \
+    PUT_PROTOTYPES(name, 12, opt)
+
+#define PUT_TAP_PROTOTYPES(n, opt) \
+    PUT_BPC_PROTOTYPES(n##tap_h,  opt) \
+    PUT_BPC_PROTOTYPES(n##tap_v,  opt) \
+    PUT_BPC_PROTOTYPES(n##tap_hv, opt)
+
+PUT_BPC_PROTOTYPES(pixels, sse4)
+PUT_BPC_PROTOTYPES(pixels, avx2)
+
+PUT_TAP_PROTOTYPES(4, sse4)
+PUT_TAP_PROTOTYPES(8, sse4)
+PUT_TAP_PROTOTYPES(4, avx2)
+PUT_TAP_PROTOTYPES(8, avx2)
+
 #if ARCH_X86_64
 #define FW_PUT(name, depth, opt) \
-static void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const uint8_t *src, ptrdiff_t srcstride, \
+void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const uint8_t *src, ptrdiff_t srcstride,        \
                                                  int height, const int8_t *hf, const int8_t *vf, int width)    \
 {                                                                                                              \
     ff_h2656_put_## name ## _ ## depth ## _##opt(dst, 2 * MAX_PB_SIZE, src, srcstride, height, hf, vf, width); \
-- 
2.44.0.windows.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes
  2024-04-15 17:35 [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes toqsxw
@ 2024-04-17 13:14 ` Nuo Mi
  2024-04-17 18:30   ` [FFmpeg-devel] 回复: " Wu Jianhua
  0 siblings, 1 reply; 4+ messages in thread
From: Nuo Mi @ 2024-04-17 13:14 UTC (permalink / raw)
  To: FFmpeg development discussions and patches; +Cc: Wu Jianhua

Hi Jianhua,
thank you for the patches.
could you add a log for each commit to explain why we need this commit?


On Tue, Apr 16, 2024 at 1:36 AM <toqsxw@outlook.com> wrote:

> From: Wu Jianhua <toqsxw@outlook.com>
>
> Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
> ---
>  libavcodec/x86/vvc/vvcdsp_init.c | 35 +++++++++++++++++++++++++++++++-
>  1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/x86/vvc/vvcdsp_init.c
> b/libavcodec/x86/vvc/vvcdsp_init.c
> index 23a3172c45..d9203f4d5f 100644
> --- a/libavcodec/x86/vvc/vvcdsp_init.c
> +++ b/libavcodec/x86/vvc/vvcdsp_init.c
> @@ -30,9 +30,42 @@
>  #include "libavcodec/vvc/dsp.h"
>  #include "libavcodec/x86/h26x/h2656dsp.h"
>
> +#define PUT_PROTOTYPE(name, depth, opt) \
> +void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const
> uint8_t *src, ptrdiff_t srcstride, int height, const int8_t *hf, const
> int8_t *vf, int width);
> +
> +#define PUT_PROTOTYPES(name, bitd, opt) \
> +        PUT_PROTOTYPE(name##2,   bitd, opt) \
> +        PUT_PROTOTYPE(name##4,   bitd, opt) \
> +        PUT_PROTOTYPE(name##8,   bitd, opt) \
> +        PUT_PROTOTYPE(name##12,  bitd, opt) \
> +        PUT_PROTOTYPE(name##16,  bitd, opt) \
> +        PUT_PROTOTYPE(name##24,  bitd, opt) \
> +        PUT_PROTOTYPE(name##32,  bitd, opt) \
> +        PUT_PROTOTYPE(name##48,  bitd, opt) \
> +        PUT_PROTOTYPE(name##64,  bitd, opt) \
> +        PUT_PROTOTYPE(name##128, bitd, opt)
> +
> +#define PUT_BPC_PROTOTYPES(name, opt) \
> +    PUT_PROTOTYPES(name,  8, opt)     \
> +    PUT_PROTOTYPES(name, 10, opt)     \
> +    PUT_PROTOTYPES(name, 12, opt)
> +
> +#define PUT_TAP_PROTOTYPES(n, opt) \
> +    PUT_BPC_PROTOTYPES(n##tap_h,  opt) \
> +    PUT_BPC_PROTOTYPES(n##tap_v,  opt) \
> +    PUT_BPC_PROTOTYPES(n##tap_hv, opt)
> +
> +PUT_BPC_PROTOTYPES(pixels, sse4)
> +PUT_BPC_PROTOTYPES(pixels, avx2)
> +
> +PUT_TAP_PROTOTYPES(4, sse4)
> +PUT_TAP_PROTOTYPES(8, sse4)
> +PUT_TAP_PROTOTYPES(4, avx2)
> +PUT_TAP_PROTOTYPES(8, avx2)
> +
>  #if ARCH_X86_64
>  #define FW_PUT(name, depth, opt) \
> -static void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst,
> const uint8_t *src, ptrdiff_t srcstride, \
> +void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, const
> uint8_t *src, ptrdiff_t srcstride,        \
>                                                   int height, const int8_t
> *hf, const int8_t *vf, int width)    \
>  {
>                                       \
>      ff_h2656_put_## name ## _ ## depth ## _##opt(dst, 2 * MAX_PB_SIZE,
> src, srcstride, height, hf, vf, width); \
> --
> 2.44.0.windows.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [FFmpeg-devel] 回复:  [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes
  2024-04-17 13:14 ` Nuo Mi
@ 2024-04-17 18:30   ` Wu Jianhua
  2024-04-20 13:38     ` [FFmpeg-devel] " Nuo Mi
  0 siblings, 1 reply; 4+ messages in thread
From: Wu Jianhua @ 2024-04-17 18:30 UTC (permalink / raw)
  To: Nuo Mi, FFmpeg development discussions and patches

> 发件人: Nuo Mi <nuomi2021@gmail.com>
> 发送时间: 2024年4月17日 6:14
> 收件人: FFmpeg development discussions and patches
> 抄送: Wu Jianhua
> 主题: Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes
> 
> Hi Jianhua,
> thank you for the patches.
> could you add a log for each commit to explain why we need this commit?

Sure. v3 sent.

> 
> On Tue, Apr 16, 2024 at 1:36 AM <toqsxw@outlook.com<mailto:toqsxw@outlook.com>> wrote:
> From: Wu Jianhua <toqsxw@outlook.com<mailto:toqsxw@outlook.com>>
> 
> Signed-off-by: Wu Jianhua <toqsxw@outlook.com<mailto:toqsxw@outlook.com>>
> ---
>  libavcodec/x86/vvc/vvcdsp_init.c | 35 +++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes
  2024-04-17 18:30   ` [FFmpeg-devel] 回复: " Wu Jianhua
@ 2024-04-20 13:38     ` Nuo Mi
  0 siblings, 0 replies; 4+ messages in thread
From: Nuo Mi @ 2024-04-20 13:38 UTC (permalink / raw)
  To: Wu Jianhua; +Cc: FFmpeg development discussions and patches

On Thu, Apr 18, 2024 at 2:30 AM Wu Jianhua <toqsxw@outlook.com> wrote:

> > 发件人: Nuo Mi <nuomi2021@gmail.com>
> > 发送时间: 2024年4月17日 6:14
> > 收件人: FFmpeg development discussions and patches
> > 抄送: Wu Jianhua
> > 主题: Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add
> put prototypes
> >
> > Hi Jianhua,
> > thank you for the patches.
> > could you add a log for each commit to explain why we need this commit?
>
> Sure. v3 sent.
>
Thank you. v3 applied.

>
> >
> > On Tue, Apr 16, 2024 at 1:36 AM <toqsxw@outlook.com<mailto:
> toqsxw@outlook.com>> wrote:
> > From: Wu Jianhua <toqsxw@outlook.com<mailto:toqsxw@outlook.com>>
> >
> > Signed-off-by: Wu Jianhua <toqsxw@outlook.com<mailto:toqsxw@outlook.com
> >>
> > ---
> >  libavcodec/x86/vvc/vvcdsp_init.c | 35 +++++++++++++++++++++++++++++++-
> > 1 file changed, 34 insertions(+), 1 deletion(-)
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-20 13:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-15 17:35 [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes toqsxw
2024-04-17 13:14 ` Nuo Mi
2024-04-17 18:30   ` [FFmpeg-devel] 回复: " Wu Jianhua
2024-04-20 13:38     ` [FFmpeg-devel] " Nuo Mi

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git