From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E41B9444C7 for ; Thu, 13 Oct 2022 15:48:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E2A2568BD69; Thu, 13 Oct 2022 18:48:54 +0300 (EEST) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2091.outbound.protection.outlook.com [40.92.99.91]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC34D68BD5C for ; Thu, 13 Oct 2022 18:48:47 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jtKbrUuiTRcBA9Km0kxb7JVX57l7+3MTvIkSZySRiPf6/sujAxKLik0C81NR/0481G3YQ8gtr7/++PUIfSQkLkEPVYaMXaJaczl6BI3lSbOLXB1d1aDlFGqTY5hFxDiipf9EG2p+MyEDghDhU/bgIqw3CunK9xOAzD/9xKqifEG9dTTTODT3sdd+DiXoq8JIXMHVDybUWOko7b8TauKcCbV7FjUXdOdAs6MzMIBd9QvbX5+4MEWH880tUfgskwsrtrwYj3XiCzK5Bk4168goUL09Ba/XtCpUmnEhE51Di7JZbH/id0BRjAL2hZ2Gz1cagjZEIA7gjYeoyueOPL8ToQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L8zgF4ZQ2UGIDKg4vrryJpXL8jUxl++8vv4EPuF7vc0=; b=XIAlaZNe9Ux6kiZNbENIkY+zSS2MlO271UA9Yh9vNJXlC+a05ptsEzn5wbhXquk8/LySsjLrTNpJFEAJqcq4Rb1pMq26w00LVpkyiPECBrPFfAPprcbUCFlGFZKMIbTHb9EzzNGowDnOa2KvKIbz1RxkwpPLiZIbV6vgl9s2eWrJ+TF8/8+5Z/ePNZJgSVa1snOEBNQiz1mjjTH9PnILWQAim6km5bvJxxDtSe5AzNG7Mo5g+WU4yfSCvwHA23cnAdphfnlDR31MuESgt8rO1W6fNk0mKV+Fb/zhrZWqYP/IEr5LJ3xvO3njjqmQdWJBP399vmuToxhq5RRTersSJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L8zgF4ZQ2UGIDKg4vrryJpXL8jUxl++8vv4EPuF7vc0=; b=pumccf0rUF6/5JjSOoTUsuZKP+hZkQipFBogXhOEQlmI8YINfcdowG2E6+Vxpl4qC88Gp+hHigPUdm37y8luT38iaGgkeykjv8YarLwqq+e/i/3IS69tBshD6IvgS+paDWwc1pC+M37kUV6HGeiVgNhJHmn+v28gf8iDkXdptqZm66FPTAyJUHH7Uh/vYoXbUpRpXDgP3YeX6Dxli0oP0gz08l8Y9Kg6gXwAkK3842hIT0N+p4HHQ6yRRS1LKBWbEJjk3ZGYzuhTgqgh7XHWmaSwIVH3YsG9jmiQAXBFpo5I+v6hCNzEUlukkpmyRA6KpwQ0a4LE8h3LlUiAeER20w== Received: from OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:186::5) by OS3P286MB1878.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:170::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.22; Thu, 13 Oct 2022 15:48:42 +0000 Received: from OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM ([fe80::5fa3:fb9a:f219:8c6f]) by OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM ([fe80::5fa3:fb9a:f219:8c6f%4]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022 15:48:42 +0000 From: Wu Jianhua To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding Thread-Index: AQHY3ikJgFdXkq4tME+m/9XuU1s84q4KmZUqgAGrKYCAACuYSg== Date: Thu, 13 Oct 2022 15:48:42 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [DLLrJ/+/kUO/CpoF30/WkRwZHOgF7iYz] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OSZP286MB2173:EE_|OS3P286MB1878:EE_ x-ms-office365-filtering-correlation-id: efce87a6-d7c6-4592-c69e-08daad3267c3 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DHNZVtWcOzLBY2pJk6zoAF54oSrE8u0SwzbVFWEDnmvA79UzYxwm58ETEfqIcNrKdHRM7KN4QYAOAeEXkBj23IVGPjNRDT35U/f2knNAVgEHWM3rKYCQydTXYahVl2kqwUtH0rbEToAiZInKiOXrKEtWTjGs6HhS+H/CIG3EqV2W55Y9BXDeAU0xaKkZFUvEvTB0TDqiIvXWzD+Men7G2GnFXphUixmf2QhtzDC/AYV3hCsZz6zNkMfqI2fUPFxXva/aPxJQMikpRXmQlzRCLsjYHFKzwEevCaNxuouyOt1wons01O/C8dYK2dxGYuGdD4nrJdKXDDIdq6MO+udJ62YMBiOBIOCYPBF9je1btiuCF8nxY2ERk3yMwn64Hr3gzoy2dopz1pCQAvK0A1mOz+iELGX7X/PYXEv9VwEDaMtuyaVC9iEf7Wu8Y5n/tKczfbS8iKgecw7lO5ljAWXxNoWXndpYBXD1bmHJya2yZxMJAJSWzyv4oCYwHA1qJuOdX8HH+eVHmH3KICRqufpUvmi66z9VC12Ps1aPREUCp48qwWn10Dp15rWh0kCMVJAuO/ZHmEWmgyGMNcBs+Mp2BHX9sdBWpBXFLX6vA/1I7ADFJATI6/LcHvJv7xW/QmAscETq04bFhMn2d2jAFumFeolkSjOtUAUTWSiKjWM1UkRo5bkkjFo7W//XCzLcpfAK x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?spIiIBC47ZpmJ/rgFlrlbC5HVAutfH+Rz+6fO/+LuvA9dM+JOqqlTVQI?= =?Windows-1252?Q?122F7+iAz3ijyKM+J3A32GFVYZEvwV4rd12RnhoKkTm1dq6c9yTcHbgP?= =?Windows-1252?Q?a5OMmiX61rAD77GffJyp12JzVTCClTw2Gy1/QoYsdH6IzlQSie469sd0?= =?Windows-1252?Q?Fvhe/T36IktJStTVp2JWs775ySquJAnUDjbFzxXHhqNaZmjPC2cHqwRx?= =?Windows-1252?Q?dQbaBTKh6nR9MCkLVnBTE14XY6KyCXhJHAxqVp/jMvzA+TvqyxiioIOd?= =?Windows-1252?Q?HovmSFD5flet7OYwRhZ1+TZsFl5nyOX0ux1mf7uENiAsjWDRFYjqy2BQ?= =?Windows-1252?Q?sixco5D3hnhPynrUs32j5Qhgo12fziCElytEb5uZF5ONFb+E2O15KqiI?= =?Windows-1252?Q?p0/j6GuWjqg1rzylxtU9OBa2DJM27B/UFY+0rqLjh2awI0tuxvaXp3LN?= =?Windows-1252?Q?xa6y0a1k4nhRj3Y2vlKVZgrvJLoawrhs6srPcHqDW+nn8qD8+cr93pA9?= =?Windows-1252?Q?lmUJE/fQ7KQ3sbCFU0tB0f1w8IPi7J0usLyflsi600BVfEqJVTbsmiYh?= =?Windows-1252?Q?FUEGQx1MGpcd/IqslcgRnztfVY2qh1dyxlobfPUTXjaPKSGVMGQcyZ1h?= =?Windows-1252?Q?AX89RdD9T8sz+TqghBJA5mgHdDrXBr5zo40NMifeuEmfpJ/fYJo731Om?= =?Windows-1252?Q?BOCJYwRR2GnwY/JzEGAB8km75yfWtB/hSsZqCfJaIwqbTfU62LK3Tdbc?= =?Windows-1252?Q?4Qe4Lf3fbtFX/DuUC8O/axjAIEYpxl98JTT1H8hXKI0U6WK3vWc0AmRo?= =?Windows-1252?Q?AQ7/VAEhjuGgLpLzKtLPpK7yB2Dl3Aqf3z0hyJF5WwRAKDWzwQ+BWaby?= =?Windows-1252?Q?6WqIV1zWxjuAxoQUUnZQGf5Z99YS9dEiMGS/kxXuF90Z/OIH2hVmhj20?= =?Windows-1252?Q?5xFn6ndWg3FGmr/sNsT5GuI1VNPawuV1zeBArQaVCDdl2I1QoE8u3KQG?= =?Windows-1252?Q?ZxbqRVHnTfY9Sf8oDAukK4g613AA8dYDfypKSsQVneG64XRxY2zfHbfj?= =?Windows-1252?Q?MIlIPLYwnMARDXwIX3sbeErPtEGMh4alaUXujvnZYgSyrEM/Z3uhtAN6?= =?Windows-1252?Q?ZgRdifXq/3cHIIxlqwObP/ahYc4z+YmaBhbB22Kk9wk6GozC/EbDkRp+?= =?Windows-1252?Q?zDZIE1HMYL/bjQLf0YKUjpms3rfImRtDsABxqnHlpw5bI8ibyfbsE7m3?= =?Windows-1252?Q?eu3Tmd3ylNd2ush0FY7u3HwdoI6agRQ6WG9L3ueJENJ84vnWBGzx0IYJ?= =?Windows-1252?Q?K/llTn7ZFgSj12y/ub/LelZ6kiwODref0vrmwgv/KgNmx0UdBcSA85bW?= =?Windows-1252?Q?ARM+Y5VhyrSXNA=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: efce87a6-d7c6-4592-c69e-08daad3267c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 15:48:42.6731 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB1878 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > Lynne wrote: > Oct 12, 2022, 13:09 by toqsxw@outlook.com: >> [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and A= V1 decoding >> >> Patch attached. >> > The Sync locking functions and the queue locking functions should > be a function pointer in the device/frame context. Vulkan has > the same issue, and that's how I did it there. This allows for > API users to plug their own locking primitives in, which they need > to in case they initialize their own contexts. I don=92t need to follow your design. > You should also document which fields API users have to set > themselves if they plan to use their own context. Where should I document them? Doesn=92t the comments enough? > Also, struct names in the public context lack an AV prefix. Will fix. And which struct? Could you add the reference? > D3D12VA_MAX_SURFACES is a terrible hack. Vendors should > fix their own drivers rather than users running out of memory. Not my responsibility as a personal developer. I know nothing about the drivers. You can ask those vendors to fix them. I don=92t think it=92s a `terrible hack`. On my test, The MAX_SURFACES is enough for the decoder. If there are any docs or the drivers fixed it, just simply remove it. Why user will run out of memory? > Also, you have code style issues, don't wrap one-line if statements > or loops in brackets. Will fix. And which loop? Could you add the reference? > ff_d3d12dec_get_suitable_max_bitstream_size is an awful function. > It does float math for sizes and has a magic mult factor of 1.5. > You have to calculate this properly. It simply calculate the size of NV12 and P010. Will add comment. > On a first look, this is what stands out. Really must be split apart > in patches. Already claim that I will split it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".