[FFmpeg-devel] 回复: [PATCH 2/2] avutil/hwcontext_d3d12va: added resource Flags support to command line

[Wu Jianhua <toqsxw@outlook.com>]

Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com>:
> Certain components require ID3D11/ID3D12 textures to be created with
> additional BindFlags or MiscFlags. FFmpeg currently provides no
> mechanism to configure these flags externally, leaving no way to
> satisfy such components without patching the library.
>
> This patch adds private device options that can be passed through
>   uav_resource=1        adds D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS
>   render_target_resource=1 adds D3D12_RESOURCE_FLAG_ALLOW_RENDER_TARGET
>   shared_resource=1        adds D3D12_HEAP_FLAG_SHARED
> ---
>  libavutil/hwcontext_d3d12va.c | 20 +++++++++++++++++++-
>  libavutil/hwcontext_d3d12va.h |  5 +++++
>  2 files changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c
> index 6507cf69c1..67c80c290e 100644
> --- a/libavutil/hwcontext_d3d12va.c
> +++ b/libavutil/hwcontext_d3d12va.c
> @@ -237,6 +237,9 @@ static AVBufferRef *d3d12va_pool_alloc(void *opaque, size_t size)
>      AVBufferRef *buf;
>      AVD3D12VAFrame *frame;
>      D3D12_HEAP_PROPERTIES props = { .Type = D3D12_HEAP_TYPE_DEFAULT };
> +
> +    hwctx->flags |= device_hwctx->flags;
> +
>      D3D12_RESOURCE_DESC desc = {
>          .Dimension        = D3D12_RESOURCE_DIMENSION_TEXTURE2D,
>          .Alignment        = 0,
> @@ -254,7 +257,7 @@ static AVBufferRef *d3d12va_pool_alloc(void *opaque, size_t size)
>      if (!frame)
>          return NULL;
>
> -    if (FAILED(ID3D12Device_CreateCommittedResource(device_hwctx->device, &props, D3D12_HEAP_FLAG_NONE, &desc,
> +    if (FAILED(ID3D12Device_CreateCommittedResource(device_hwctx->device, &props, device_hwctx->heap_flags, &desc,
>          D3D12_RESOURCE_STATE_COMMON, NULL, &IID_ID3D12Resource, (void **)&frame->texture))) {
>          av_log(ctx, AV_LOG_ERROR, "Could not create the texture\n");
>          goto fail;
> @@ -673,6 +676,21 @@ static int d3d12va_device_create(AVHWDeviceContext *hwdev, const char *device,
>          }
>      }
>
> +    ctx->flags = 0;
> +
> +    // "shader_resouce" already enabled by default.
> +
> +    if (av_dict_get(opts, "uav_resource", NULL, 0))
> +        ctx->flags |= D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS;
> +
> +    if (av_dict_get(opts, "render_target_resource", NULL, 0))
> +        ctx->flags |= D3D12_RESOURCE_FLAG_ALLOW_RENDER_TARGET;
> +
> +    ctx->heap_flags = D3D12_HEAP_FLAG_NONE;
> +
> +    if (av_dict_get(opts, "shared_resource", NULL, 0))
> +        ctx->heap_flags |= D3D12_HEAP_FLAG_SHARED;
> +
>      return 0;
>  }
>
> diff --git a/libavutil/hwcontext_d3d12va.h b/libavutil/hwcontext_d3d12va.h
> index 212a6a6146..f1aea52559 100644
> --- a/libavutil/hwcontext_d3d12va.h
> +++ b/libavutil/hwcontext_d3d12va.h
> @@ -75,6 +75,11 @@ typedef struct AVD3D12VADeviceContext {
>      void (*lock)(void *lock_ctx);
>      void (*unlock)(void *lock_ctx);
>      void *lock_ctx;
> +    /**
> +     * Need to pass value to frames context from command line
> +    */
> +    D3D12_RESOURCE_FLAGS flags;
> +    D3D12_HEAP_FLAGS heap_flags;
>  } AVD3D12VADeviceContext;
>
>  /**
>

Hi Dmitrii,

The AVD3D12VAFramesContext includes dedicated resource flag configuration
for resource management. These flags can be directly accessed and extended
with heap flags as needed, since resource allocation is handled at the frame
level rather than globally at the device level. Decoder and encoder instances
can independently initialize their frame contexts, each with tailored resource
flags. For example, the encoder has used the following resource flags, but
the decoder hasn't.

- D3D12_RESOURCE_FLAG_VIDEO_ENCODE_REFERENCE_ONLY
- D3D12_RESOURCE_FLAG_DENY_SHADER_RESOURCE

Thanks,
Jianhua
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".