From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 26/28] avcodec/mpegvideoencdsp: Factor draw_edges out in its own context
Date: Tue, 7 May 2024 00:52:44 +0200 (CEST)
Message-ID: <NxF5dR5--3-9@lynne.ee> (raw)
In-Reply-To: <GV1P250MB07379CD2C3C128004AAFF4258F1C2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
May 6, 2024, 23:53 by andreas.rheinhardt@outlook.com:
> This allows to remove a dependency of the dirac decoder (!)
> on mpegvideoenc.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> configure | 7 +-
> libavcodec/Makefile | 1 +
> libavcodec/diracdec.c | 14 +--
> libavcodec/drawedgesdsp.c | 61 ++++++++++
> libavcodec/drawedgesdsp.h | 35 ++++++
> libavcodec/mpegvideo.h | 2 +
> libavcodec/mpegvideo_enc.c | 9 +-
> libavcodec/mpegvideoencdsp.c | 32 ------
> libavcodec/mpegvideoencdsp.h | 6 -
> libavcodec/snowenc.c | 13 ++-
> libavcodec/x86/Makefile | 1 +
> libavcodec/x86/drawedgesdsp.c | 157 ++++++++++++++++++++++++++
> libavcodec/x86/mpegvideo.c | 2 +-
> libavcodec/x86/mpegvideoencdsp_init.c | 118 -------------------
> 14 files changed, 281 insertions(+), 177 deletions(-)
> create mode 100644 libavcodec/drawedgesdsp.c
> create mode 100644 libavcodec/drawedgesdsp.h
> create mode 100644 libavcodec/x86/drawedgesdsp.c
>
26, 27 and 28 all LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-06 22:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 8:25 [FFmpeg-devel] [PATCH 1/9] configure: Add missing dirac_decoder->qpeldsp dependency Andreas Rheinhardt
2024-05-05 8:27 ` [FFmpeg-devel] [PATCH 2/9] configure: Add missing pdv decoder->inflate_wrapper dependency Andreas Rheinhardt
2024-05-05 8:27 ` [FFmpeg-devel] [PATCH 3/9] configure: Add missing atrac3p(al) decoder->sinewin dependency Andreas Rheinhardt
2024-05-05 8:27 ` [FFmpeg-devel] [PATCH 4/9] configure: Add missing ftr decoder->adts_header dependency Andreas Rheinhardt
2024-05-05 8:27 ` [FFmpeg-devel] [PATCH 5/9] avcodec/Makefile, v408(dec|enc): Remove remnants of AYUV codecs Andreas Rheinhardt
2024-05-05 8:27 ` [FFmpeg-devel] [PATCH 6/9] Remove remnants of prores_lgpl decoder Andreas Rheinhardt
2024-05-05 8:27 ` [FFmpeg-devel] [PATCH 7/9] avcodec/Makefile: Correct name of cbd2_dpcm decoder Andreas Rheinhardt
2024-05-05 8:27 ` [FFmpeg-devel] [PATCH 8/9] configure: Add wmv2dsp->qpeldsp dependency Andreas Rheinhardt
2024-05-05 8:27 ` [FFmpeg-devel] [PATCH 9/9] avcodec/Makefile: Fix intrax8 objects Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 10/24] avformat/Makefile: Add asf_muxer->asf_tags.o dependency Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 11/24] avfilter/Makefile: Add missing tiltshelf entry Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 12/24] avfilter/Makefile: Add missing colormap->framesync dependency Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 13/24] avfilter/vf_xmedian: Define OFFSET, FLAGS macros unconditionally Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 14/24] avfilter/Makefile: Add scale(2ref)->framesync dependency Andreas Rheinhardt
2024-05-07 21:11 ` Frank Plowman
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 15/24] avfilter/vsrc_testsrc: Fix compilation of colorchart filter Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 16/24] avfilter/Makefile: Add missing guided->framesync dependency Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 17/24] avfilter/vf_convolution: Fix compilation with sobel disabled Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 18/24] avfilter/x86/Makefile: Add missing dependencies for sobel filter Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 19/24] avfilter/Makefile: Add missing multiply->framesync dependency Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 20/24] avfilter/vf_lut3d: Fix standalone build of lut1d Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 21/24] avfilter/x86/Makefile: Fix standalone build of haldclut filter Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 22/24] avfilter/Makefile: Add missing identity->framesync dependency Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 23/24] configure: Add missing identity filter->scene_sad dependency Andreas Rheinhardt
2024-05-05 13:40 ` [FFmpeg-devel] [PATCH 24/24] avfilter/Makefile: Add missing morpho->framesync dependency Andreas Rheinhardt
2024-05-06 21:52 ` [FFmpeg-devel] [PATCH 25/28] avcodec/x86/mpegvideoencdsp_init: Remove bits_per_raw_sample check Andreas Rheinhardt
2024-05-07 0:10 ` Michael Niedermayer
2024-05-07 8:49 ` Andreas Rheinhardt
2024-05-06 21:52 ` [FFmpeg-devel] [PATCH 26/28] avcodec/mpegvideoencdsp: Factor draw_edges out in its own context Andreas Rheinhardt
2024-05-06 22:52 ` Lynne [this message]
2024-05-06 21:52 ` [FFmpeg-devel] [PATCH 27/28] avcodec/mpegvideoencdsp: Pass bitexact flag directly Andreas Rheinhardt
2024-05-06 21:52 ` [FFmpeg-devel] [PATCH 28/28] avcodec/diracdec: Don't use EDGE_WIDTH from mpegpicture.h Andreas Rheinhardt
2024-05-07 8:55 ` [FFmpeg-devel] [PATCH 1/9] configure: Add missing dirac_decoder->qpeldsp dependency Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NxF5dR5--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git