From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/aac/aacdec: Fix linking errors with only one decoder enabled
Date: Tue, 7 May 2024 00:47:49 +0200 (CEST)
Message-ID: <NxF4fN0--3-9@lynne.ee> (raw)
In-Reply-To: <GV1P250MB0737A29C0776175536E98E1D8F1C2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
May 7, 2024, 00:38 by andreas.rheinhardt@outlook.com:
> This is achieved by using function pointers for AAC SBR functions.
> This unfortunately necessitated to use void* in
> ff_aac_sbr_apply(_fixed).
> Fixes ticket #10999.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/aac/aacdec.c | 35 ++++++---------------------
> libavcodec/aac/aacdec.h | 7 ++++++
> libavcodec/aac/aacdec_proc_template.c | 6 +++++
> libavcodec/aacsbr.h | 4 +--
> libavcodec/aacsbr_template.c | 3 ++-
> 5 files changed, 25 insertions(+), 30 deletions(-)
>
Very nice, thanks
This sets us up to detemplate SBR too in the future.
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-05-06 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 22:37 Andreas Rheinhardt
2024-05-06 22:47 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NxF4fN0--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git