From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9245849075 for ; Thu, 2 May 2024 01:21:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B37E468D777; Thu, 2 May 2024 04:21:19 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4A6E568CF59 for ; Thu, 2 May 2024 04:21:12 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id D8D1B10600E8 for ; Thu, 2 May 2024 01:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1714612871; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=5ikm6xmfDIKj2AUj9OLY0Ym+wmVGjfCXbEe/wi9QEpo=; b=QaozkrhLO6hgNWrCdX2EU1/+suNJ812IIzVC/BjIc00J2kJrxEZXq/5UasqLLh3L CMjkfI2EEAy1LOs1IpVZlcf1GJMWw0CjS/s3F7B9RCGFiyc9PNrtt5o0exw0wOJ71vY xl3hDgjjDD6r1idB/BHpQMG+z3ePIudWJ2PGfE2p+WYRmZ8eYX2fw8RBpU2cpPADqPy 9aQJhO1gxwN07nQ0hyvGlkfH2G4h2KoKMXweQVBCL4oLJH5acjCuBVHCySs69oZkVmK CwQwRB8VwnEuR26NlozNfWzXbm0XmsQjaqhJQRS5Sf2D1RSyN5XlkVCmsoWUcklsgbS aO8fjn4fPg== Date: Thu, 2 May 2024 03:21:11 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20240502004150.3627661-3-michael@niedermayer.cc> References: <20240502004150.3627661-1-michael@niedermayer.cc> <20240502004150.3627661-3-michael@niedermayer.cc> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/7] avcodec/avfft: Remove dead code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: May 2, 2024, 02:42 by michael@niedermayer.cc: > Fixes: CID1543204 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/avfft.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/avfft.c b/libavcodec/avfft.c > index f6787937f67..0f43f30b776 100644 > --- a/libavcodec/avfft.c > +++ b/libavcodec/avfft.c > @@ -158,7 +158,7 @@ RDFTContext *av_rdft_init(int nbits, enum RDFTransformType trans) > return NULL; > } > > - s->stride = (trans == DFT_C2R) ? sizeof(AVComplexFloat) : sizeof(float); > + s->stride = sizeof(float); > s->len = 1 << nbits; > s->inv = trans == IDFT_C2R; > That's not right. While it's true that currently the stride parameter in av_tx_fn is unused for RDFTs, that may not always be the case, and the documentation requires that the stride is valid and set to the value that the current implementation assumes, so that nothing breaks once that is implemented. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".