From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 71B3348313 for ; Mon, 22 Apr 2024 20:36:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4DD4C68D367; Mon, 22 Apr 2024 23:36:27 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3114368D239 for ; Mon, 22 Apr 2024 23:36:21 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id C266E1060122 for ; Mon, 22 Apr 2024 20:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1713818180; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=gNf+N/VJnxu1wfPv3k7KXB7uA+iNuotxE20OfH28NgU=; b=TX0jQ44UqS4tSqJx49VspBFwmkIvl0h9scx4rUpB+MI/eEYehRtrHvmOhgVe8Aw1 M0LT50+yED/6lem9OSg0MUomucAgH2iNkpCZC/VhZW23gcEkRTvuVL/ZXNp4Xz0AFEJ /wPArJF0pbpB6zANTLbcSBo5U7oHq46u4IRJUTXEdeJiB5z0fh+6EKshtozoClKkufD jqYIP4hJKlp3uaPSzfkbUAekxVOHO9b+PBv8JWMiTA/hfrrAJddm9DUIfw41tWrxGHF EQOHWbnq1jv7XPgVwhpkxdUC+ZgM99PXThvSw5wbgqP8DcMNNPC0jdVW2WaWPEkFO+Y A3jvRIBCXw== Date: Mon, 22 Apr 2024 22:36:20 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <951824f2-abe7-4ed2-a2cf-12ecf67d27dd@jkqxz.net> References: <951824f2-abe7-4ed2-a2cf-12ecf67d27dd@jkqxz.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Apr 22, 2024, 22:31 by sw@jkqxz.net: > --- > Actually match the specification. (Though I'm guessing this field isn't actually used if things pass anyway?) > > libavcodec/av1dec.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index 69da08b686..79a30a114d 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c > @@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s) > int ref_order_hint = s->ref[ref_slot].order_hint; > > frame->order_hints[ref_name] = ref_order_hint; > - frame->ref_frame_sign_bias[ref_name] = > - get_relative_dist(seq, ref_order_hint, frame->order_hint); > + if (!seq->enable_order_hint) { > + frame->ref_frame_sign_bias[ref_name] = 0; > + } else { > + frame->ref_frame_sign_bias[ref_name] = > + get_relative_dist(seq, ref_order_hint, > + frame->order_hint) > 0; > + } > } > } > LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".