From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation
Date: Mon, 22 Apr 2024 22:36:20 +0200 (CEST)
Message-ID: <Nw6WWen--7-9@lynne.ee> (raw)
In-Reply-To: <951824f2-abe7-4ed2-a2cf-12ecf67d27dd@jkqxz.net>
Apr 22, 2024, 22:31 by sw@jkqxz.net:
> ---
> Actually match the specification. (Though I'm guessing this field isn't actually used if things pass anyway?)
>
> libavcodec/av1dec.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index 69da08b686..79a30a114d 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s)
> int ref_order_hint = s->ref[ref_slot].order_hint;
>
> frame->order_hints[ref_name] = ref_order_hint;
> - frame->ref_frame_sign_bias[ref_name] =
> - get_relative_dist(seq, ref_order_hint, frame->order_hint);
> + if (!seq->enable_order_hint) {
> + frame->ref_frame_sign_bias[ref_name] = 0;
> + } else {
> + frame->ref_frame_sign_bias[ref_name] =
> + get_relative_dist(seq, ref_order_hint,
> + frame->order_hint) > 0;
> + }
> }
> }
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-22 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 20:31 Mark Thompson
2024-04-22 20:36 ` Lynne [this message]
2024-04-22 20:45 ` Mark Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Nw6WWen--7-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git