From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3C72047724 for ; Fri, 19 Apr 2024 11:30:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22F5668D32B; Fri, 19 Apr 2024 14:30:01 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 759FD68D223 for ; Fri, 19 Apr 2024 14:29:54 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 784961060140 for ; Fri, 19 Apr 2024 11:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1713526193; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=wtZ2+2SxF81AmezBzV4B+mvN+YU631pi165xMO4nqUQ=; b=AGvk3HmcEPmMqSkZED0iqMbSXLC0ZeFIUWLZ8ZutuVAuKsZMUZMPUVP0WwnLFV3w 1qhUCl2AHluAsi8yivafxeleHsEiz3YhlWgwHCckk+fmj5RzNsOKIMfxgA376VxQPAq u270BsIqjIpZaSLkwdby2TfrPqAGUrrDOhILO0FX9lnTq9KLu4mKCF8s1mkBgxrKbqZ IXSTFsQSmysiOGbntDJ4eCa6OXdxzBlcpuOz2k/1otOe/DL0VvXMIak0GoqNY8px4qe GIpDASnPr1IftTQeNNmlKjFTPSfG0+JW6vgKgWgO5XOsY4wlSpGqM2+qmk/FlSnfeyu VfwpwHRq4A== Date: Fri, 19 Apr 2024 13:29:53 +0200 (CEST) From: Lynne To: Diego Felix de Souza via ffmpeg-devel Message-ID: In-Reply-To: <20240419083851.746482-1-ddesouza@nvidia.com> References: <20240415143932.338380-1-ddesouza@nvidia.com> <20240419083851.746482-1-ddesouza@nvidia.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: High bit depth encoding for HEVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Apr 19, 2024, 10:39 by ffmpeg-devel@ffmpeg.org: > From: Diego Felix de Souza > > Adding 10-bit encoding support for HEVC if the input is 8-bit. In > case of 8-bit input content, NVENC performs an internal CUDA 8 to > 10-bit conversion of the input prior to encoding. Currently, only > AV1 supports encoding 8-bit content as 10-bit. > > Signed-off-by: Diego Felix de Souza > --- > libavcodec/nvenc.c | 10 +++++----- > libavcodec/nvenc_hevc.c | 3 +++ > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 794174a53f..e48224347d 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -514,7 +514,7 @@ static int nvenc_check_capabilities(AVCodecContext *avctx) > } > > ret = nvenc_check_cap(avctx, NV_ENC_CAPS_SUPPORT_10BIT_ENCODE); > - if (IS_10BIT(ctx->data_pix_fmt) && ret <= 0) { > + if ((IS_10BIT(ctx->data_pix_fmt) || ctx->highbitdepth) && ret <= 0) { > av_log(avctx, AV_LOG_WARNING, "10 bit encode not supported\n"); > return AVERROR(ENOSYS); > } > @@ -1420,8 +1420,8 @@ static av_cold int nvenc_setup_hevc_config(AVCodecContext *avctx) > break; > } > > - // force setting profile as main10 if input is 10 bit > - if (IS_10BIT(ctx->data_pix_fmt)) { > + // force setting profile as main10 if input is 10 bit or if it should be encoded as 10 bit > + if (IS_10BIT(ctx->data_pix_fmt) || ctx->highbitdepth) { > cc->profileGUID = NV_ENC_HEVC_PROFILE_MAIN10_GUID; > avctx->profile = AV_PROFILE_HEVC_MAIN_10; > } > @@ -1435,8 +1435,8 @@ static av_cold int nvenc_setup_hevc_config(AVCodecContext *avctx) > hevc->chromaFormatIDC = IS_YUV444(ctx->data_pix_fmt) ? 3 : 1; > > #ifdef NVENC_HAVE_NEW_BIT_DEPTH_API > - hevc->inputBitDepth = hevc->outputBitDepth = > - IS_10BIT(ctx->data_pix_fmt) ? NV_ENC_BIT_DEPTH_10 : NV_ENC_BIT_DEPTH_8; > + hevc->inputBitDepth = IS_10BIT(ctx->data_pix_fmt) ? NV_ENC_BIT_DEPTH_10 : NV_ENC_BIT_DEPTH_8; > + hevc->outputBitDepth = (IS_10BIT(ctx->data_pix_fmt) || ctx->highbitdepth) ? NV_ENC_BIT_DEPTH_10 : NV_ENC_BIT_DEPTH_8; > #else > hevc->pixelBitDepthMinus8 = IS_10BIT(ctx->data_pix_fmt) ? 2 : 0; > #endif > diff --git a/libavcodec/nvenc_hevc.c b/libavcodec/nvenc_hevc.c > index b949cb1bd7..d54e5f2512 100644 > --- a/libavcodec/nvenc_hevc.c > +++ b/libavcodec/nvenc_hevc.c > @@ -183,6 +183,9 @@ static const AVOption options[] = { > { "fullres", "Two Pass encoding is enabled where first Pass is full resolution", > 0, AV_OPT_TYPE_CONST, { .i64 = NV_ENC_TWO_PASS_FULL_RESOLUTION }, 0, 0, VE, .unit = "multipass" }, > #endif > +#ifdef NVENC_HAVE_NEW_BIT_DEPTH_API > + { "highbitdepth", "Enable 10 bit encode for 8 bit input",OFFSET(highbitdepth),AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, > +#endif > #ifdef NVENC_HAVE_LDKFS > { "ldkfs", "Low delay key frame scale; Specifies the Scene Change frame size increase allowed in case of single frame VBV and CBR", > OFFSET(ldkfs), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, UCHAR_MAX, VE }, > -- > 2.34.1 > Rather than introducing a new setting, could you instead use AVCodecContext.sw_pix_fmt? It's currently documented as being unused for encoding, but it fits the purpose. Vulkan can also use it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".