From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 638D94941F
	for <ffmpegdev@gitmailbox.com>; Thu, 11 Apr 2024 05:42:48 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B07F468CF80;
	Thu, 11 Apr 2024 08:42:45 +0300 (EEST)
Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 11A2F6801F2
 for <ffmpeg-devel@ffmpeg.org>; Thu, 11 Apr 2024 08:42:38 +0300 (EEST)
Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10])
 by w4.tutanota.de (Postfix) with ESMTP id 6CF47106015E
 for <ffmpeg-devel@ffmpeg.org>; Thu, 11 Apr 2024 05:42:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1712814157; 
 s=s1; d=lynne.ee;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=OanGkh1nAB26zgbryN2j5tAzu7I9Yz5SBbktZsi4rgQ=;
 b=DD/DHgdF5hroI9ZAK8DeYi8VcYCdLfH9PfzymdZHyrPpAb6W63stNcH+k7yxPomG
 Fy60uHsb2cTs6ZyfpUvN7HtjgLF+ksxa4B5N7QjbpC3l49+7qqi3Vz5Y9UzX57l1XHz
 TK3kDV8CWFCQ26gXeWkuaZZMUuOe7pS/lPJq2u94s05AC7OY+E8HsBlnJQLwaBo3Wto
 8Vui21zkV1vjTSs+CJEsJWLXlPRKzTCk+kcrxo702ZpqbOjCbs9zzagh8lT1H98LTYN
 nJoHFoUMmwns+9KCBRuGWVHO4GlaJCVfAw2UaKUQmgTdO1cUuOW+dcP66jyPgSFGu2/
 Ay0HpOVTCQ==
Date: Thu, 11 Apr 2024 07:42:37 +0200 (CEST)
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <NvAfTyz--3-9@lynne.ee>
In-Reply-To: <20240410215655.GR6420@pb2>
References: <NuwZLzA--3-9@lynne.ee> <NuwZLzA--3-9@lynne.ee-NuwcmRV----9>
 <Nv7uHIG--3-9@lynne.ee> <20240410181811.GP6420@pb2>
 <20240410215655.GR6420@pb2>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/NvAfTyz--3-9@lynne.ee/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Apr 10, 2024, 23:57 by michael@niedermayer.cc:

> On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote:
>
>> On Wed, Apr 10, 2024 at 06:48:26PM +0200, Lynne wrote:
>> > Apr 8, 2024, 09:36 by dev@lynne.ee:
>> > 
>> > > The following patchset refactors the AAC decoder step by step,
>> > > removing all large-scale templating and abstracting away typed
>> > > DSP functions from symbol parsing.
>> > >
>> > > This series saves 110Kib of binary data from libavcodec.so
>> > > when compiled with Clang 18 with -O3, after stripping.
>> > >
>> > > The patchset can also be viewed here:
>> > > https://github.com/cyanreg/FFmpeg/tree/aac_cleanup
>> > >
>> > > Fate passes on each step, and I've been running this patchset for
>> > > a week with no issues.
>> > >
>> > > This also prepares the decoder for USAC support.
>> > >
>> > 
>> > I've rebased the linked repo to current git master if anyone
>> > wants to test.
>>
>> thanks, i will try to test it
>>
>
> make fate-source
>
> TEST    source
> --- ./tests/ref/fate/source	2024-04-08 18:26:00.670129617 +0200
> +++ tests/data/fate/source	2024-04-10 23:56:18.032896853 +0200
> @@ -22,6 +22,13 @@
>  compat/djgpp/math.h
>  compat/float/float.h
>  compat/float/limits.h
> +libavcodec/aac/aacdec.h
> +libavcodec/aac/aacdec_fixed_coupling.h
> +libavcodec/aac/aacdec_fixed_dequant.h
> +libavcodec/aac/aacdec_fixed_prediction.h
> +libavcodec/aac/aacdec_float_coupling.h
> +libavcodec/aac/aacdec_float_prediction.h
> +libavcodec/aac/aacdec_latm.h
>  libavcodec/bitstream_template.h
>  tools/decode_simple.h
>  Use of av_clip() where av_clip_uintp2() could be used:
> Test source failed. Look at tests/data/fate/source.err for details.
> tests/Makefile:310: recipe for target 'fate-source' failed
> make: *** [fate-source] Error 1
>

Thanks for testing. Fixed both issues in the repo.
Was only testing with fate-aac while developing.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".