Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

[Lynne <dev@lynne.ee>]

Apr 10, 2024, 06:54 by anton@khirnov.net:

> Quoting James Almer (2024-04-10 03:23:46)
>
>> On 4/9/2024 10:11 PM, Andrew Kelley wrote:
>> > On 4/9/24 17:04, Lynne wrote:
>> >> LGTM.
>> >> That's how I wrote the AAC patchset as well.
>> >
>> > Thank you for the review, Lynne.
>> >
>> > What is the next step? I do not have commit access.
>>
>> Applied it, thanks.
>>
>
> WTF?
>
> Please revert immediately.
>

In the past, even for sketchy commits with many follow-up fixes needed,
and with multiple reverts requested, no one dared to revert someone
else's commits out of fear of starting a revert war.

You didn't issue a warning that you were going to revert, you didn't
ask any of us who approved it, and you hardly allowed for anyone
involved to respond. The only reason given on IRC was:
> <psykose> rather than argue about whatever this is it would be more interesting to know what in the patch is controversial
> <@elenril> I don't like it

Please don't do this again. This project isn't a dictatorship, and it
creates precedence for someone to do the same with your commits.

What don't you like about this commit? It eliminates ambiguity
and any danger of header conflicts for subsystems being switched
to local folders.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".