Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andrew Kelley <andrew@ziglang.org>,
	Ffmpeg Devel <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths
Date: Wed, 10 Apr 2024 02:04:17 +0200 (CEST)
Message-ID: <Nv4JS-A--3-9@lynne.ee> (raw)
In-Reply-To: <20240409211334.138302-1-andrew@ziglang.org>

Apr 9, 2024, 23:24 by andrew@ziglang.org:

> Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
>
> This makes code copy-pastable to other parts of the ffmpeg codebase, as
> well as simplifying the build script.
>
> It also reduces ambiguity, since there are many instances of same-named
> header files existing in both libavformat/ and libavcodec/
> subdirectories.
> ---
>  libavcodec/bsf/Makefile               |  2 --
>  libavcodec/bsf/aac_adtstoasc.c        | 16 ++++++++--------
>  libavcodec/bsf/av1_frame_merge.c      |  8 ++++----
>  libavcodec/bsf/av1_frame_split.c      |  8 ++++----
>  libavcodec/bsf/av1_metadata.c         | 10 +++++-----
>  libavcodec/bsf/chomp.c                |  4 ++--
>  libavcodec/bsf/dca_core.c             |  8 ++++----
>  libavcodec/bsf/dts2pts.c              | 12 ++++++------
>  libavcodec/bsf/dump_extradata.c       |  4 ++--
>  libavcodec/bsf/dv_error_marker.c      |  4 ++--
>  libavcodec/bsf/eac3_core.c            |  8 ++++----
>  libavcodec/bsf/evc_frame_merge.c      | 12 ++++++------
>  libavcodec/bsf/extract_extradata.c    | 22 +++++++++++-----------
>  libavcodec/bsf/filter_units.c         |  6 +++---
>  libavcodec/bsf/h264_metadata.c        | 20 ++++++++++----------
>  libavcodec/bsf/h264_mp4toannexb.c     | 10 +++++-----
>  libavcodec/bsf/h264_redundant_pps.c   | 16 ++++++++--------
>  libavcodec/bsf/h265_metadata.c        | 16 ++++++++--------
>  libavcodec/bsf/h266_metadata.c        | 12 ++++++------
>  libavcodec/bsf/hapqa_extract.c        |  8 ++++----
>  libavcodec/bsf/hevc_mp4toannexb.c     | 10 +++++-----
>  libavcodec/bsf/imx_dump_header.c      |  6 +++---
>  libavcodec/bsf/media100_to_mjpegb.c   |  6 +++---
>  libavcodec/bsf/mjpeg2jpeg.c           |  8 ++++----
>  libavcodec/bsf/mjpega_dump_header.c   |  8 ++++----
>  libavcodec/bsf/movsub.c               |  4 ++--
>  libavcodec/bsf/mpeg2_metadata.c       | 12 ++++++------
>  libavcodec/bsf/mpeg4_unpack_bframes.c |  8 ++++----
>  libavcodec/bsf/noise.c                |  4 ++--
>  libavcodec/bsf/null.c                 |  2 +-
>  libavcodec/bsf/opus_metadata.c        |  4 ++--
>  libavcodec/bsf/pcm_rechunk.c          |  4 ++--
>  libavcodec/bsf/pgs_frame_merge.c      |  4 ++--
>  libavcodec/bsf/prores_metadata.c      |  4 ++--
>  libavcodec/bsf/remove_extradata.c     | 14 +++++++-------
>  libavcodec/bsf/setts.c                |  4 ++--
>  libavcodec/bsf/showinfo.c             |  4 ++--
>  libavcodec/bsf/trace_headers.c        |  6 +++---
>  libavcodec/bsf/truehd_core.c          | 10 +++++-----
>  libavcodec/bsf/vp9_metadata.c         | 10 +++++-----
>  libavcodec/bsf/vp9_raw_reorder.c      |  8 ++++----
>  libavcodec/bsf/vp9_superframe.c       |  6 +++---
>  libavcodec/bsf/vp9_superframe_split.c |  8 ++++----
>  libavcodec/bsf/vvc_mp4toannexb.c      | 10 +++++-----
>  44 files changed, 184 insertions(+), 186 deletions(-)
>

LGTM.
That's how I wrote the AAC patchset as well.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".