From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 60A1149B82 for ; Wed, 3 Apr 2024 04:04:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B7AE68D01B; Wed, 3 Apr 2024 07:04:55 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3EB1C68B23B for ; Wed, 3 Apr 2024 07:04:49 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id B1AC710600E8 for ; Wed, 3 Apr 2024 04:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1712117088; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=vOTHk/Axgof6K/TXWPfNHnv3wS27n689ITJSzQxi0xc=; b=RaC/xWKgew+XcjTKK782oy8LQZ2bBDacP9+g+1ORYMYgNc8xVlr+3ljmRDpFK5j2 pPtjDXYDth1bY0JDIxkFgogupGD/Cfqv0rGYBphudfCHjUY/Lpnzj5KdUSrxJsQnrT8 ciBRm3K66/0hin251HzwtesuoXaCnyAcHCVNMYM93wNKjxsFZYJr5ttVprzgdLNO5BX TyJ+TQXSg4+iv0rcgchceD/MF3bG5xsVbseyW+JDkKKNAuSGyq0RaUnHsbRJxhc+DZU tTSeL+tPmZRp1GaWe/SRj/xc5rFo308DwHfICjAmtKlCKcfsU98+7vQ07OBT/AUTdD9 ZRa5vUXWsA== Date: Wed, 3 Apr 2024 06:04:48 +0200 (CEST) From: Lynne To: Ted Meyer via ffmpeg-devel Message-ID: In-Reply-To: <20240402214435.3928635-1-tmathmeyer@google.com> References: <20240402214435.3928635-1-tmathmeyer@google.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] Add AAC_xHE case to aacdec_template.c for demuxing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Apr 2, 2024, 23:45 by ffmpeg-devel@ffmpeg.org: > From: Ted Meyer > > The parser needs to be able to be created when demuxing, otherwise the > channel count and layout can't be successfully generated. > > Signed-off-by: Ted Meyer > --- > libavcodec/aacdec_template.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c > index aa856d7fe1..9afa3aba83 100644 > --- a/libavcodec/aacdec_template.c > +++ b/libavcodec/aacdec_template.c > @@ -1022,6 +1022,7 @@ static int decode_audio_specific_config_gb(AACDecContext *ac, > case AOT_AAC_LTP: > case AOT_ER_AAC_LC: > case AOT_ER_AAC_LD: > + case AOT_USAC_NOSBR: > if ((ret = decode_ga_specific_config(ac, avctx, gb, get_bit_alignment, > m4ac, m4ac->chan_config)) < 0) > return ret; > That's a really invalid workaround which also disables warning users that xHE-AAC is not implemented. The xHE-AAC header is not an extension of the GA header to decode anything properly, even without SBR. I'll be posting patches in a few days to add xHE-AAC decoding support which also fixes remuxing. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".