From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 13F2C48B89 for ; Thu, 7 Mar 2024 04:04:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1F0E568CD95; Thu, 7 Mar 2024 06:04:03 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D387668AB8E for ; Thu, 7 Mar 2024 06:03:56 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 47A301060277 for ; Thu, 7 Mar 2024 04:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1709784236; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=ZprE+v5ZjDXx8sTD/3BnCXAZJu2Cs6WscSMLanKtIKY=; b=YdcIx1qXG6ri9ldpX9bkCXyB51co0fjA90WmDKgVFLaHe//H5T7pjwWMXLTQHHIH 786c0ajIntNUEVtsij8N6UHeOWBiC8a2YEH2zqLOwKkRuqMc62KRm4fkL77xkVq1lCC AV5i4FjiTUmBCzGU/mu205R3ePbHAnftzx8vUYpm9d5a09tPxFQlOQNxa+bQVqX/2df JiNSULgdfu1feKMPjE/zKUHB0J+CBsAsYgVlNFdG/z+Bs4LYwGK+UksASXb3V7YgTZn 9MMe0/ephzS9/0Il0XebD6TtxEqUjSzpMPjmWWxgltMYeqt5Zv+M/v8ESlTnYfdH3R8 vsgL3d04nw== Date: Thu, 7 Mar 2024 05:03:56 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vulkan_decode: Remove always-false check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Mar 7, 2024, 01:33 by andreas.rheinhardt@outlook.com: > These fields are set for all Vulkan decoding hwaccels; > they would be useless if it were different. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vulkan_decode.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c > index 233b5792d8..91929d165f 100644 > --- a/libavcodec/vulkan_decode.c > +++ b/libavcodec/vulkan_decode.c > @@ -780,11 +780,7 @@ static int vulkan_decode_get_profile(AVCodecContext *avctx, AVBufferRef *frames_ > VkVideoFormatPropertiesKHR *ret_info; > uint32_t nb_out_fmts = 0; > > - if (!vk_desc->decode_op || !vk_desc->decode_extension) { > - av_log(avctx, AV_LOG_ERROR, "Unsupported codec for Vulkan decoding: %s!\n", > - avcodec_get_name(avctx->codec_id)); > - return AVERROR(ENOSYS); > - } else if (!(vk_desc->decode_extension & ctx->s.extensions)) { > + if (!(vk_desc->decode_extension & ctx->s.extensions)) { > av_log(avctx, AV_LOG_ERROR, "Device does not support decoding %s!\n", > avcodec_get_name(avctx->codec_id)); > return AVERROR(ENOSYS); > Patchset LGTM Thanks for the cleanups _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".