Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vulkan_decode: Remove always-false check

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vulkan_decode: Remove always-false check
Date: Thu, 7 Mar 2024 05:03:56 +0100 (CET)
Message-ID: <NsM4Ez9--3-9@lynne.ee> (raw)
In-Reply-To: <GV1SPRMB00526EA8FB8A56FE48AB7C688F202@GV1SPRMB0052.EURP250.PROD.OUTLOOK.COM>

Mar 7, 2024, 01:33 by andreas.rheinhardt@outlook.com:

> These fields are set for all Vulkan decoding hwaccels;
> they would be useless if it were different.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/vulkan_decode.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c
> index 233b5792d8..91929d165f 100644
> --- a/libavcodec/vulkan_decode.c
> +++ b/libavcodec/vulkan_decode.c
> @@ -780,11 +780,7 @@ static int vulkan_decode_get_profile(AVCodecContext *avctx, AVBufferRef *frames_
>  VkVideoFormatPropertiesKHR *ret_info;
>  uint32_t nb_out_fmts = 0;
>  
> -    if (!vk_desc->decode_op || !vk_desc->decode_extension) {
> -        av_log(avctx, AV_LOG_ERROR, "Unsupported codec for Vulkan decoding: %s!\n",
> -               avcodec_get_name(avctx->codec_id));
> -        return AVERROR(ENOSYS);
> -    } else if (!(vk_desc->decode_extension & ctx->s.extensions)) {
> +    if (!(vk_desc->decode_extension & ctx->s.extensions)) {
>  av_log(avctx, AV_LOG_ERROR, "Device does not support decoding %s!\n",
>  avcodec_get_name(avctx->codec_id));
>  return AVERROR(ENOSYS);
>

Patchset LGTM
Thanks for the cleanups
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".