From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1967649B6F for ; Sun, 3 Mar 2024 21:49:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C771068D3DF; Sun, 3 Mar 2024 23:49:18 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A07EB68D164 for ; Sun, 3 Mar 2024 23:49:12 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 416AB10602E5 for ; Sun, 3 Mar 2024 21:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1709502552; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=LuEkDF+GvhfOzXdLE1c7H7Hc3qLH5aPrvJj/pibKWWs=; b=1PGhtIjaUjxnDOslrxubSu18e9d2nQ5+nQ/zeTYlRw11gMpKU1V3xKwMLbh2vScu 8NMxWgjEQqclxWYW2CXnaMo2n8XRUOkQsT0qmGJ+njjbe5dUonotiZs9vzRusmPnk4s aFgXacutCDqXuTB4CMBkEcnPZPFUkVspwrDldMtuBpCYa6CsiVW98dWUl39nIrz7Iaa HNKaswNM180qTZyeTxMkYSmS0/UM714juBodICIHVB6BdMqHiQbZH1Ak+yWo65HxJYX Rm+I8O5HSyxDk+XMZ9f6ifGaKgd92r5sNKTIOjaMiKFUbtz/xlL+DvQchhz/JfC32Qz wtLdmLNPgw== Date: Sun, 3 Mar 2024 22:49:12 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 8/8] avutil/vulkan: Move functions only used by lavfi to it X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Mar 3, 2024, 19:42 by andreas.rheinhardt@outlook.com: > lavu/vulkan.c is duplicated into lavfi, lavc and lavu, > yet lots of functions in it are only used by lavfi. > This commit moves them to lavfi, saving 6544B of .text > from both lavc and lavu as well as some .rodata and > .data.rel.ro (in total 7880B each for lavc and lavu). > > Signed-off-by: Andreas Rheinhardt > --- > One could also move this stuff to new files; e.g. both the shader > and pipeline parts could be moved into files of their own > which would then only be compiled for lavfi. > > libavfilter/vulkan_filter.c | 764 +++++++++++++++++++++++++++++++++++ > libavfilter/vulkan_filter.h | 177 ++++++++ > libavfilter/vulkan_glslang.c | 1 + > libavfilter/vulkan_shaderc.c | 1 + > libavutil/vulkan.c | 760 ---------------------------------- > libavutil/vulkan.h | 176 -------- > 6 files changed, 943 insertions(+), 936 deletions(-) > Patchset LGTM, except, sadly, the last commit. We will need to implement shader-based film grain application as Intel hardware does not support it, so most of the functions will be used. Also, a GSoC project I have to implement shader-based encoders also depends on this code. 6k is a lot, but anyone serious about weight should be using LTO, which would get rid of it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".