Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vulkan_decode: Un-sparse extensions table

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vulkan_decode: Un-sparse extensions table
Date: Sun, 3 Mar 2024 14:03:10 +0100 (CET)
Message-ID: <Ns3OtEw--3-9@lynne.ee> (raw)
In-Reply-To: <AS8P250MB0744815E4DB41F77E622ADCD8F5C2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Mar 3, 2024, 12:35 by andreas.rheinhardt@outlook.com:

> Only three of the 226 (== AV_CODEC_ID_AV1) entries
> have been used. Unsparsing this table is especially
> important given that this array lives in .data.rel.ro.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> Instead of parallel tables, one could also merge VkCodecMap and
> VkExtensionProperties (i.e. putting one of the latter inside
> the former) if preferred.
>
> libavcodec/vulkan_decode.c | 28 ++++++++++++++++++++++------
> 1 file changed, 22 insertions(+), 6 deletions(-)
>

LGTM on commits 1 and 3.
Would you mind keeping the designated initializers from
commit 2 but still keeping it into vulkan_video.c?
Would save on needing to deduplicate it in the future.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".