From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EDF5049A20 for ; Mon, 26 Feb 2024 14:43:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B14B168C7F8; Mon, 26 Feb 2024 16:43:30 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F003B68034D for ; Mon, 26 Feb 2024 16:43:24 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 91AD8106019B for ; Mon, 26 Feb 2024 14:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1708958604; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=6w57Y1tHy9ZMfEDo3GYYEI12lPJzNDMstlDDD6YiQvk=; b=ZrvK8KUBFu88uwH0uxM3QORXMn6XNt7ehy4XF3PAXQJJxI99zSosbDlcm8VU1QZw v7RSxsZ0VLsFzwDw1FwuEhvuU9SIJANryDxvUAzU5OwgofEh6Y7S9wBzH6z1ICo2JLF SEksc2p2lWX7PsViXGkmaAnrcxtQz/lPNjV2F7znIq2XDhrTqb6fW+r7Lx3/BGjKRQV o2RakECHbdshUNOY5EVjsnI8ozPIaQEBlzOBEuznlivyAJNjRJsAo28p0LAfZT7/KcS pYKOLzH3y6W1ecoEtu/DvFBXnH8OQX1xFPdvVFBZ4yu+6urwXSppvtTwlRrKaaODhLA I7JboEIU7Q== Date: Mon, 26 Feb 2024 15:43:24 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 6/8] avcodec/aacsbr_template: Avoid using AACDecContext; pass logctx directly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Feb 26, 2024, 02:25 by andreas.rheinhardt@outlook.com: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aacsbr_template.c | 131 ++++++++++++++++++----------------- > 1 file changed, 66 insertions(+), 65 deletions(-) > > diff --git a/libavcodec/aacsbr_template.c b/libavcodec/aacsbr_template.c > index ce3834e2dc..72bec96d2c 100644 > --- a/libavcodec/aacsbr_template.c > +++ b/libavcodec/aacsbr_template.c > @@ -237,15 +237,15 @@ static int array_min_int16(const int16_t *array, int nel) > return min; > } > Patchset LGTM, except this commit. Would you mind leaving AACDecContext usage here? SBR is still technically part of the decoder, and it has been useful for 2 of my unmerged patches to have access to the header. I think SBR went too hard on abstracting itself, maybe for a hypothetical sbr mp3 reuse. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".