Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/tx: print debug log at trace level
Date: Wed, 21 Feb 2024 17:32:54 +0100 (CET)
Message-ID: <NrBVp1D--3-9@lynne.ee> (raw)
In-Reply-To: <20240221144333.1874-1-jamrial@gmail.com>

Feb 21, 2024, 15:43 by jamrial@gmail.com:

> The output of TX is extremely verbose and makes it harder to find other debug
> log messages, so only print it at trace level.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavutil/tx.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libavutil/tx.c b/libavutil/tx.c
> index f991618b4b..eefb3e2ac7 100644
> --- a/libavutil/tx.c
> +++ b/libavutil/tx.c
> @@ -643,7 +643,7 @@ static void print_cd_info(const FFTXCodelet *cd, int prio, int len, int print_pr
>  if (print_prio)
>  av_bprintf(&bp, ", prio: %i", prio);
>  
> -    av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
> +    av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
>  }
>  
>  static void print_tx_structure(AVTXContext *s, int depth)
> @@ -651,7 +651,7 @@ static void print_tx_structure(AVTXContext *s, int depth)
>  const FFTXCodelet *cd = s->cd_self;
>  
>  for (int i = 0; i <= depth; i++)
> -        av_log(NULL, AV_LOG_DEBUG, "    ");
> +        av_log(NULL, AV_LOG_TRACE, "    ");
>  
>  print_cd_info(cd, cd->prio, s->len, 0);
>  
> @@ -816,10 +816,10 @@ av_cold int ff_tx_init_subtx(AVTXContext *s, enum AVTXType type,
>  AV_QSORT(cd_matches, nb_cd_matches, TXCodeletMatch, cmp_matches);
>  
>  #if !CONFIG_SMALL
> -    av_log(NULL, AV_LOG_DEBUG, "%s\n", bp.str);
> +    av_log(NULL, AV_LOG_TRACE, "%s\n", bp.str);
>  
>  for (int i = 0; i < nb_cd_matches; i++) {
> -        av_log(NULL, AV_LOG_DEBUG, "    %i: ", i + 1);
> +        av_log(NULL, AV_LOG_TRACE, "    %i: ", i + 1);
>  print_cd_info(cd_matches[i].cd, cd_matches[i].prio, 0, 1);
>  }
>  #endif
> @@ -929,7 +929,7 @@ av_cold int av_tx_init(AVTXContext **ctx, av_tx_fn *tx, enum AVTXType type,
>  *tx  = tmp.fn[0];
>  
>  #if !CONFIG_SMALL
> -    av_log(NULL, AV_LOG_DEBUG, "Transform tree:\n");
> +    av_log(NULL, AV_LOG_TRACE, "Transform tree:\n");
>  print_tx_structure(*ctx, 0);
>  #endif 
>

It's a chunk of few dozen lines, I don't think it's spammy enough for trace.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-02-21 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 14:43 James Almer
2024-02-21 16:32 ` Lynne [this message]
2024-02-21 16:37   ` James Almer
2024-02-22  3:16     ` Lynne
2024-02-22  3:32       ` James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=NrBVp1D--3-9@lynne.ee \
    --to=dev@lynne.ee \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git