From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E4C3495EC for ; Thu, 15 Feb 2024 01:18:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1938768D218; Thu, 15 Feb 2024 03:18:23 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E28E68C4E0 for ; Thu, 15 Feb 2024 03:18:16 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 6AED3106025B for ; Thu, 15 Feb 2024 01:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1707959896; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=9iAvDPaOnEOJDArmN50/3NLT2zsBADl5TAnb29jRN80=; b=Z3JnN2mhjai3s6wvLWM2FYs97aZ8eOcTdTn+4Bjn+kIqv7upe7A8lfLtHE8g84DN NGecp5VzTFXBAMhYwQm9fTl8YvnLEhRa5V449p33gEfPFGzbH3V7mwcjrQJ4P6dDW+Z vILoerhj82YIwJig1+zr91HFD3+HYedxl05ZdOJpR196uCU6YGPrOw6PuRl2dqOSShG JQ1NEPzTwvb5teVBAlgyEN2XfSvRU4zDttff7MKXg5xhwZ85eXwX6KFXX6cZYvAClas XAmqv4vWqiaVmtPheCEcKe0Ag1C7bNyOsguMeI0DmanWy0TxGo8sbn+6jZnN5j375/b KBpxF7pdPw== Date: Thu, 15 Feb 2024 02:18:16 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] av_tx_init: accept NULL scale for RDFT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Feb 14, 2024, 21:45 by pross@xvid.org: > Make av_tx_init() agree with documentation: > > * Real to complex and complex to real DFTs. > * For the float and int32 variants, the scale type is 'float', while for > * the double variant, it's a 'double'. If scale is NULL, 1.0 will be used > * as a default. > --- > libavutil/tx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavutil/tx.c b/libavutil/tx.c > index d6740071b9..cc360cff31 100644 > --- a/libavutil/tx.c > +++ b/libavutil/tx.c > @@ -914,9 +914,9 @@ av_cold int av_tx_init(AVTXContext **ctx, av_tx_fn *tx, enum AVTXType type, > if (!(flags & AV_TX_INPLACE)) > flags |= FF_TX_OUT_OF_PLACE; > > - if (!scale && ((type == AV_TX_FLOAT_MDCT) || (type == AV_TX_INT32_MDCT))) > + if (!scale && ((type == AV_TX_FLOAT_MDCT) || (type == AV_TX_INT32_MDCT) || (type == AV_TX_FLOAT_RDFT) || (AV_TX_INT32_RDFT))) > scale = &default_scale_f; > - else if (!scale && (type == AV_TX_DOUBLE_MDCT)) > + else if (!scale && ((type == AV_TX_DOUBLE_MDCT) || (type == AV_TX_DOUBLE_RDFT))) > scale = &default_scale_d; > > ret = ff_tx_init_subtx(&tmp, type, flags, NULL, len, inv, scale); > LGTM thnx _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".