From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9D9D149596 for ; Tue, 13 Feb 2024 12:10:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ACBFA68CAAB; Tue, 13 Feb 2024 14:10:10 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AE5F768CAAB for ; Tue, 13 Feb 2024 14:10:03 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 86840106031E for ; Tue, 13 Feb 2024 12:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1707826202; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=DJcIUfT1tnbu+uLFLJqwIaugLx7n6gmDycL3Yv5Xgus=; b=K2T8Cl3PvPaqeKaoHYf34tTbdVhaD6NlLAhYDJr7nimF+6nfijbvhp9LPV6Hx0Vu RgTvEeGnUGD+wKe3pGJDagLW4XLJm9YyiN1dkKTnsOfSEXH39hHepTW96lTr9+I/2Px 6f26XaIHNFTcK52SKj2RVeD9/ojOYbYV3R0YqxXo40PBEHNyWgfCR34XYsEtbt8vKt4 UvHAuToVEPmf88MPkQRZmGYCYWlbJGNNXyEkjzzEyUgGVgqEBUn+49zOQHRkHe8wvx7 aDyWhOvv5hxkk11xy+q7ARF4UmiGC4TqwuwJmB+Ncl10GxAsEMfN8+AhzKNlMhqthlp 8wrcLa8Tvg== Date: Tue, 13 Feb 2024 13:10:02 +0100 (CET) From: Lynne To: Benjamin Cheng via ffmpeg-devel Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Feb 13, 2024, 01:59 by ffmpeg-devel@ffmpeg.org: > On Sun Feb 11, 2024 at 10:15 AM EST, Lynne wrote: > >> From: Lynne >> Date: Fri, 19 Jan 2024 10:49:02 +1000 >> Subject: [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API >> >> Most of this patch was written by Dave Airlie , >> with some additions by me. >> --- >> >> >> - ap->av1_pic_info = (VkVideoDecodeAV1PictureInfoMESA) { >> - .sType = VK_STRUCTURE_TYPE_VIDEO_DECODE_AV1_PICTURE_INFO_MESA, >> - .frame_header = &ap->av1_frame_header, >> - .tile_list = &ap->tile_list, >> + ap->av1_pic_info = (VkVideoDecodeAV1PictureInfoKHR) { >> + .sType = VK_STRUCTURE_TYPE_VIDEO_DECODE_AV1_PICTURE_INFO_KHR, >> + .pStdPictureInfo = &ap->std_pic_info, >> + .tileCount = ap->tile_count, >> + .pTileOffsets = ap->tile_offsets, >> > > Mentioned this on IRC earlier, but this means the driver always get > pTileOffsets = NULL, since ap->tile_offsets only gets filled out during > vk_av1_decode_slice(). > Thanks, already fixed it, I did report back on IRC. >> + >> + ap->loop_restoration = (StdVideoAV1LoopRestoration) { >> + .FrameRestorationType[0] = remap_lr_type[frame_header->lr_type[0]], >> + .FrameRestorationType[1] = remap_lr_type[frame_header->lr_type[1]], >> + .FrameRestorationType[2] = remap_lr_type[frame_header->lr_type[2]], >> + .LoopRestorationSize[0] = AV1_RESTORATION_TILESIZE_MAX >> (2 - frame_header->lr_unit_shift), >> + .LoopRestorationSize[1] = ap->loop_restoration.LoopRestorationSize[0] >> frame_header->lr_uv_shift, >> + .LoopRestorationSize[2] = ap->loop_restoration.LoopRestorationSize[0] >> frame_header->lr_uv_shift, >> + }; >> > > Not sure what the C spec says, but at least on GCC 13.2.1 it seems like > the assignment for LoopRestorationSize[1] and [2] happens before the > initalization of LoopRestorationSize[0]. > Nothing here on gcc-12, gcc-14 and clang-19. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".