From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 46F5549389 for ; Thu, 8 Feb 2024 19:42:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 37E6968D115; Thu, 8 Feb 2024 21:42:08 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5C2A368CC86 for ; Thu, 8 Feb 2024 21:42:01 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 1039110602E1 for ; Thu, 8 Feb 2024 19:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1707421320; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=tnvFmW8e8+lhCSlbw1Gro5t5vw0AMknhshoi+RxLrhk=; b=yTadTTLtClFXtfGz76wBgBboYNbMtoiTdVooT9kkj8tgi2vYEiZAc6rUkgSAezZP 69QM3Gnk2llRaZ9NAhKSrqresOC7n1Pf6fAfBvZvHxuaRDV5cv//kS0sUFl2x2NciXt Xmc0zUYI6i3BI+yzWKhr4e69w847eRHvwadEuNcxtkD9Z7qeMviCLwY8s5cdyuBKtnF 5tKEg9Bf0D9XwLLZ/HcEc2LO0GiVm5phxXr/BN+waSNAvHQGTXuxjCJs6enCrEH5w2x PSVOJkWD7oMkjNSNurCXpIaDZL9KKd2Wssd/jBksfSaOSmUUB/Uj6oTkNec9+UQX4jP H/QXQOBYVg== Date: Thu, 8 Feb 2024 20:42:00 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20240208190709.38110-2-connorbworley@gmail.com> References: <20240208190709.38110-1-connorbworley@gmail.com> <20240208190709.38110-2-connorbworley@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/dxv: treat DXT5-tagged files as DXT4 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Feb 8, 2024, 20:07 by connorbworley@gmail.com: > DXV files seem to misnomer DXT5 and really encode DXT4 with > premultiplied alpha. At least, this is what Resolume alley does. > > To check, encode some input with alpha as "Normal Quality, With Alpha" > in Alley, then decode the output with this change -- results are true > to the original input compared to git-master. > > Signed-off-by: Connor Worley > --- > libavcodec/dxv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c > index 5923811b29..1e6791e63f 100644 > --- a/libavcodec/dxv.c > +++ b/libavcodec/dxv.c > @@ -1074,7 +1074,8 @@ static int dxv_decode(AVCodecContext *avctx, AVFrame *frame, > break; > case MKBETAG('D', 'X', 'T', '5'): > decompress_tex = dxv_decompress_dxt5; > - ctx->tex_funct = ctx->texdsp.dxt5_block; > + /* DXV misnomers DXT5, alpha is premultiplied so use DXT4 instead */ > + ctx->tex_funct = ctx->texdsp.dxt4_block; > ctx->tex_rat = 4; > ctx->tex_step = 16; > msgcomp = "DXTR5"; > Pushed along with the rest of the DXT patches. Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".