[FFmpeg-devel] [PATCH] x86/tx_float: enable SIMD for sizes over 131072

[FFmpeg-devel] [PATCH] x86/tx_float: enable SIMD for sizes over 131072

[Lynne]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

The tables for the new sizes were added last year due
to being required for SDR.
However, the assembly was never updated to use them.

Patch attached.


[-- Attachment #2: 0001-x86-tx_float-enable-SIMD-for-sizes-over-131072.patch --]
[-- Type: text/x-diff, Size: 1264 bytes --]

From ccfd9366025105a7dba0471965856b12d73bbd17 Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Thu, 18 Jan 2024 17:30:29 +0100
Subject: [PATCH] x86/tx_float: enable SIMD for sizes over 131072

The tables for the new sizes were added last year due
to being required for SDR.
However, the assembly was never updated to use them.
---
 libavutil/x86/tx_float.asm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/libavutil/x86/tx_float.asm b/libavutil/x86/tx_float.asm
index e1533a8595..42006848f1 100644
--- a/libavutil/x86/tx_float.asm
+++ b/libavutil/x86/tx_float.asm
@@ -46,7 +46,7 @@
 %endif
 
 %assign i 16
-%rep 14
+%rep 18
 cextern tab_ %+ i %+ _float ; ff_tab_i_float...
 %assign i (i << 1)
 %endrep
@@ -1385,7 +1385,11 @@ FFT_SPLIT_RADIX_DEF 8192,  .16384pt
 FFT_SPLIT_RADIX_DEF 16384, .32768pt
 FFT_SPLIT_RADIX_DEF 32768, .65536pt
 FFT_SPLIT_RADIX_DEF 65536, .131072pt
-FFT_SPLIT_RADIX_DEF 131072
+FFT_SPLIT_RADIX_DEF 131072, .262144pt
+FFT_SPLIT_RADIX_DEF 262144, .524288pt
+FFT_SPLIT_RADIX_DEF 524288, .1048576pt
+FFT_SPLIT_RADIX_DEF 1048576, .2097152pt
+FFT_SPLIT_RADIX_DEF 2097152
 
 ;===============================================================================
 ; Final synthesis + deinterleaving code
-- 
2.43.0


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] x86/tx_float: enable SIMD for sizes over 131072

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1129 bytes --]

On Thu, Jan 18, 2024 at 05:33:41PM +0100, Lynne wrote:
> The tables for the new sizes were added last year due
> to being required for SDR.
> However, the assembly was never updated to use them.
> 
> Patch attached.
> 

>  tx_float.asm |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> a8a354082090729d8b772e84f82266a210371d10  0001-x86-tx_float-enable-SIMD-for-sizes-over-131072.patch
> From ccfd9366025105a7dba0471965856b12d73bbd17 Mon Sep 17 00:00:00 2001
> From: Lynne <dev@lynne.ee>
> Date: Thu, 18 Jan 2024 17:30:29 +0100
> Subject: [PATCH] x86/tx_float: enable SIMD for sizes over 131072
> 
> The tables for the new sizes were added last year due
> to being required for SDR.
> However, the assembly was never updated to use them.
> ---
>  libavutil/x86/tx_float.asm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] x86/tx_float: enable SIMD for sizes over 131072

[Paul B Mahol]

Please push this ASAP, my all private projects depends on it.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] x86/tx_float: enable SIMD for sizes over 131072

[Lynne]

Feb 6, 2024, 12:14 by onemda@gmail.com:

> Please push this ASAP, my all private projects depends on it.
>

Pushed, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".