From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] vvcdec: add TODO for combining transform, lmcs_scale_chroma, and add_residual
Date: Sat, 6 Jan 2024 21:03:14 +0100 (CET)
Message-ID: <NnVMpeo--3-9@lynne.ee> (raw)
In-Reply-To: <TYSPR06MB643370FD131D1F0B5312B3DEAA60A@TYSPR06MB6433.apcprd06.prod.outlook.com>
Jan 3, 2024, 16:53 by nuomi2021@gmail.com:
> Thanks for the suggestion from Lynne.
> ---
> libavcodec/vvc/vvc_intra.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/vvc/vvc_intra.c b/libavcodec/vvc/vvc_intra.c
> index 43de312a71..214ad38c8c 100644
> --- a/libavcodec/vvc/vvc_intra.c
> +++ b/libavcodec/vvc/vvc_intra.c
> @@ -552,6 +552,8 @@ static void itransform(VVCLocalContext *lc, TransformUnit *tu, const int tu_idx,
>
> if (chroma_scale)
> fc->vvcdsp.intra.lmcs_scale_chroma(lc, temp, tb->coeffs, w, h, cu->x0, cu->y0);
> + // TODO: Address performance issue here by combining transform, lmcs_scale_chroma, and add_residual into one function.
> + // Complete this task before implementing ASM code.
> fc->vvcdsp.itx.add_residual(dst, chroma_scale ? temp : tb->coeffs, w, h, stride);
>
> if (tu->joint_cbcr_residual_flag && tb->c_idx)
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-06 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 15:52 Nuo Mi
2024-01-06 20:03 ` Lynne [this message]
2024-01-07 1:11 ` Nuo Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NnVMpeo--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git