Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder
Date: Tue, 2 Jan 2024 16:57:00 +0100 (CET)
Message-ID: <Nn9t6aB--3-9@lynne.ee> (raw)
In-Reply-To: <CAFXK13fvZQ3PSa+tG4qin1iFzmMBwymJ+BjvdPMCuirwnNQUBQ@mail.gmail.com>

Jan 2, 2024, 14:22 by nuomi2021@gmail.com:

> On Mon, Jan 1, 2024 at 11:13 PM Lynne <dev@lynne.ee> wrote:
>
>>
>>
>>
>> Jan 1, 2024, 15:14 by nuomi2021@gmail.com:
>>
>> > +
>> > +//fixme
>> > +static void vvc_refill2(CABACContext* c) {
>> >
>>
>> Fix what?
>> Also, wrong coding style.
>>
> The function is a copy of refill2 in cabac_functions.h, including the style.
> The refill2 is protected by get_cabac_inline.
> On x86, get_cabac_inline is only defined when HAVE_7REGS &&
> !BROKEN_COMPILER is true.
> It can be challenging to figure out how to get refill2 defined in this
> context.
> Let us use https://github.com/ffvvc/FFmpeg/issues/178 to track this
>

Are you thinking about sharing the code later on?
If not, then there's no reason to have the duplicated function
and style issues.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".