From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 10EFC483A0 for ; Mon, 1 Jan 2024 15:04:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C20B368CE36; Mon, 1 Jan 2024 17:04:16 +0200 (EET) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8FAE568CE1C for ; Mon, 1 Jan 2024 17:04:09 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 2B07510601EF for ; Mon, 1 Jan 2024 15:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1704121449; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=jy4yF1V3K1tGXhg3Xd7Nu/L0OjYKrpL//rh9h9s/lbY=; b=dN5jQJ3nz8enUVGyByLFd5NAgKSfuxzTjCnqfbYw5lmWGmQuzekPKPxqc6gQcM+A dyfSRAnhNwaes2nql20mNNAHVev6yIjOy4R2UWpLx8qOrtdL9UjIbGeMRUycpzuFnem Nm948WxmGBHwUVPqR85JJraU953R98e1nmO3mJxCjoUTB84A6Xo4RI8Hja0+MCoCXLh b3a7n1+Rcgqd0ZtoVtfcr8VvKrQeV7eUyfGjadTwSVRKN63EhBW32FTwZ2zeg5rOkju JHOSwvoqqpbwEi1y94T1v8pJhxKU1xCGzTY0TiHW9o4mOs2BQEtDXCmVeReT3SOuLX3 /HsFFgRZ6A== Date: Mon, 1 Jan 2024 16:04:09 +0100 (CET) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: <20240101141239.6623-1-nuomi2021@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v9 06/13] vvcdec: add inter prediction X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jan 1, 2024, 15:15 by nuomi2021@gmail.com: > + > +//////////////////////////////////////////////////////////////////////////////// > +// > +//////////////////////////////////////////////////////////////////////////////// > What's with these markers? > +static void FUNC(put_pixels)(int16_t *dst, > + const uint8_t *_src, const ptrdiff_t _src_stride, > + const int height, const int8_t *hf, const int8_t *vf, const int width) > +{ > + const pixel *src = (const pixel *)_src; > + const ptrdiff_t src_stride = _src_stride / sizeof(pixel); > + > + for (int y = 0; y < height; y++) { > + for (int x = 0; x < width; x++) > + dst[x] = src[x] << (14 - BIT_DEPTH); > + src += src_stride; > + dst += MAX_PB_SIZE; > + } > +} > av_image_copy(AV_PIX_FMT_GRAY14, input_format)? Also, why is the decoder using 14-bits internally rather than expanding it to 16-bits? Headroom to avoid overflows? > + > +static void FUNC(put_uni_pixels)(uint8_t *_dst, const ptrdiff_t _dst_stride, > + const uint8_t *_src, const ptrdiff_t _src_stride, const int height, > + const int8_t *hf, const int8_t *vf, const int width) > +{ > + const pixel *src = (const pixel *)_src; > + pixel *dst = (pixel *)_dst; > + const ptrdiff_t src_stride = _src_stride / sizeof(pixel); > + const ptrdiff_t dst_stride = _dst_stride / sizeof(pixel); > + > + for (int y = 0; y < height; y++) { > + memcpy(dst, src, width * sizeof(pixel)); > + src += src_stride; > + dst += dst_stride; > + } > +} > av_image_copy()? Also, this function is identical for all bit depths. > + > +enum TxType { > + DCT2, > + DST7, > + DCT8, > + N_TX_TYPE, > +}; > + > +enum TxSize { > + TX_SIZE_2, > + TX_SIZE_4, > + TX_SIZE_8, > + TX_SIZE_16, > + TX_SIZE_32, > + TX_SIZE_64, > + N_TX_SIZE, > +}; > Could you prefix these enums with VVC_? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".