From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 6EC2C47B41
	for <ffmpegdev@gitmailbox.com>; Mon,  1 Jan 2024 14:50:55 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B678368CE28;
	Mon,  1 Jan 2024 16:50:52 +0200 (EET)
Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5C9BA68CA6C
 for <ffmpeg-devel@ffmpeg.org>; Mon,  1 Jan 2024 16:50:46 +0200 (EET)
Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10])
 by w4.tutanota.de (Postfix) with ESMTP id 679CE1060122
 for <ffmpeg-devel@ffmpeg.org>; Mon,  1 Jan 2024 14:50:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1704120645; 
 s=s1; d=lynne.ee;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=xCUspvlzd8mw1PntEFQ8qjQR8YLNZTTegjPfxIiUnD4=;
 b=aEibJB13+fv4tRc+3apun3K9OLuvXFxPNA6M2hS8NF1rV/wLWDFklJjq55pQadt5
 Y7DznaK95ugrFCFlsHLEpoYGzXBADt/9yKl5hLe6Zpz4tQhtV520mEMKSV4636XC1Cw
 BYXrQUSXHg06GJ4BCNXNYEDAuY7IwVhGyJ8KSpbo/BySQek/p142eIzSVPVvFhFN/or
 5FONZa1JigtTe6ws/4cdK4G8dEi4bGnCrlvPofD57I4VBT33bQQsIgpRY8DVxf4rM0E
 BGHGI9CDINUX1rJXC8PYMe+F9DyTcA5EtrSA+nfkIp0oqBfGO0dROsbxYvNyzz17z7e
 EbpZ098iYQ==
Date: Mon, 1 Jan 2024 15:50:45 +0100 (CET)
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <Nn4VML---3-9@lynne.ee>
In-Reply-To: <TYSPR06MB643369DCA30C6FACB0065E2CAA62A@TYSPR06MB6433.apcprd06.prod.outlook.com>
References: <20240101141239.6623-1-nuomi2021@gmail.com>
 <TYSPR06MB643369DCA30C6FACB0065E2CAA62A@TYSPR06MB6433.apcprd06.prod.outlook.com>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH v9 07/13] vvcdec: add inv transform 1d
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/Nn4VML---3-9@lynne.ee/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Jan 1, 2024, 15:16 by nuomi2021@gmail.com:

> + */
> +void ff_vvc_inv_dct2_4(int *coeffs, const ptrdiff_t stride, const size_t nz)
> +{
> +    const int a = 64, b = 83, c = 36;
> +    const int x0 = coeffs[0 * stride], x1 = coeffs[1 * stride];
> +    const int x2 = coeffs[2 * stride], x3 = coeffs[3 * stride];
> +    const int E[2] = {
> +        a * (x0 + G2(+x2)),
> +        a * (x0 + G2(-x2)),
> +    };
> +    const int O[2] = {
> +        b * x1 + G2(+c * x3),
> +        c * x1 + G2(-b * x3),
> +    };
> +
> +    coeffs[0 * stride] = E[0] + O[0];
> +    coeffs[1 * stride] = E[1] + O[1];
> +    coeffs[2 * stride] = E[1] - O[1];
> +    coeffs[3 * stride] = E[0] - O[0];
> +}
>

Is that how the transforms are specified (matrices)?
Also, why are you not adding the transformed residual *directly* to the input.
This is how all our other decoders do this, because it skips a copy. This isn't
something you can quite optimize later on.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".