Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne <dev@lynne.ee>
To: Ffmpeg Devel <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function
Date: Mon, 4 Dec 2023 08:51:23 +0100 (CET)
Message-ID: <NknnrNO--3-9@lynne.ee> (raw)

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

This is a convenience function, which is required to be called by decoders
needing to skip samples every time.
It automatically creates and increments side data.

This function is a simplified version of an earlier patch. It is only
able to add additional delay, rather than insert or override any.


[-- Attachment #2: 0001-decode-add-ff_decode_skip_samples-function.patch --]
[-- Type: text/x-diff, Size: 2132 bytes --]

From 3045ac286538641076ce4547cda677c3b159877f Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Mon, 30 Oct 2023 05:38:17 +0100
Subject: [PATCH 1/2] decode: add ff_decode_skip_samples function

This is a convenience function, which is required to be called by decoders
needing to skip samples every time.
It automatically creates and increments side data.

This function is a simplified version of an earlier patch. It is only
able to add additional delay, rather than insert or override any.
---
 libavcodec/decode.c | 17 +++++++++++++++++
 libavcodec/decode.h |  8 ++++++++
 2 files changed, 25 insertions(+)

diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index 2cfb3fcf97..450d63d947 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -299,6 +299,23 @@ static int64_t guess_correct_pts(AVCodecContext *ctx,
     return pts;
 }
 
+int ff_decode_skip_samples(AVCodecContext *avctx, AVFrame *frame, uint32_t skip)
+{
+    uint32_t val = 0;
+    AVFrameSideData *side = av_frame_get_side_data(frame, AV_FRAME_DATA_SKIP_SAMPLES);
+    if (!side) {
+        side = av_frame_new_side_data(frame, AV_FRAME_DATA_SKIP_SAMPLES, 10);
+        if (!side)
+            return AVERROR(ENOMEM);
+    }
+
+    val += AV_RL32(side->data);
+    val += skip;
+    AV_WL32(side->data, val);
+
+    return 0;
+}
+
 static int discard_samples(AVCodecContext *avctx, AVFrame *frame, int64_t *discarded_samples)
 {
     AVCodecInternal *avci = avctx->internal;
diff --git a/libavcodec/decode.h b/libavcodec/decode.h
index daf1a67444..c83476208c 100644
--- a/libavcodec/decode.h
+++ b/libavcodec/decode.h
@@ -155,4 +155,12 @@ int ff_hwaccel_frame_priv_alloc(AVCodecContext *avctx, void **hwaccel_picture_pr
 const AVPacketSideData *ff_get_coded_side_data(const AVCodecContext *avctx,
                                                enum AVPacketSideDataType type);
 
+/**
+ * Skip samples in an AVFrame.
+ *
+ * @param skip amount of samples to skip unconditionally
+ */
+int ff_decode_skip_samples(AVCodecContext *avctx, AVFrame *frame,
+                           uint32_t skip);
+
 #endif /* AVCODEC_DECODE_H */
-- 
2.43.0


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2023-12-04  7:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04  7:51 Lynne [this message]
     [not found] ` <NknnrNO--3-9@lynne.ee-Nknnuzj----9>
2023-12-04  7:52   ` [FFmpeg-devel] [PATCH 2/2] aacdec: fix single-sample delay for SBR streams Lynne
2023-12-05  1:47     ` Michael Niedermayer
  -- strict thread matches above, loose matches on Subject: below --
2023-10-30  5:09 [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function Lynne
2023-11-04 10:41 ` Anton Khirnov
2023-11-04 16:22 ` Derek Buitenhuis
2023-11-04 17:32   ` Derek Buitenhuis
2023-11-04 17:41   ` Michael Niedermayer
2023-11-04 20:33   ` Lynne
2023-11-04 23:02   ` Martin Storsjö
2023-11-04 23:27     ` Lynne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=NknnrNO--3-9@lynne.ee \
    --to=dev@lynne.ee \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git