From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2D7B04773A for ; Sun, 22 Oct 2023 01:55:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFC5268CA21; Sun, 22 Oct 2023 04:55:54 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6721568C884 for ; Sun, 22 Oct 2023 04:55:48 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 9F4841060148 for ; Sun, 22 Oct 2023 01:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1697939747; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=Rk1vvQdDABbCoD8mTM7JVLxvDK5cT3M9B44szlJd9Mk=; b=CAgvHt6kXrVF2VdTRsPyw9Zmq6mypwTmGELVRqjvoIysyJk9l9QOFrVeHJyesYNd d7OMZGpheFET/M5vRoUUBt/p2252+ar/rcTeaKyM0NVEZ+GOjBFBMFSKl8ke2laKv1I OsAz158SrSa1MSYWR/rwJj/3qjbOXl3BnuvW26u95CNZvfG0zkrAi+KAdzt7lDHs3Xd w0CgHbE0HTskuP3v6pw1TmOHf0a445rNWO0LfkvtKHFp2HHDvW2YZr+ssewPjtcHAPk Po8dY/WXOijY2V6giwHmKYl3UtccKoAgdat9n17AjNg583wUPZHcpQ8P3vqsIty0myc VxJh9dG5sA== Date: Sun, 22 Oct 2023 03:55:47 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20231022003520.17154-5-michael@niedermayer.cc> References: <20231022003520.17154-1-michael@niedermayer.cc> <20231022003520.17154-5-michael@niedermayer.cc> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 5/6] avutil/tx_template: fix integer ovberflwo in fft3() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Oct 22, 2023, 02:36 by michael@niedermayer.cc: > Fixes: signed integer overflow: -1028966111 + -1314089526 cannot be represented in type 'int' > Fixes: 63174/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5853273711837184 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavutil/tx_template.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c > index 8dc3d2519c1..a2c27465cbc 100644 > --- a/libavutil/tx_template.c > +++ b/libavutil/tx_template.c > @@ -185,10 +185,9 @@ static av_always_inline void fft3(TXComplex *out, TXComplex *in, > BF(tmp[1].re, tmp[2].im, in[1].im, in[2].im); > BF(tmp[1].im, tmp[2].re, in[1].re, in[2].re); > > - out[0*stride].re = tmp[0].re + tmp[2].re; > - out[0*stride].im = tmp[0].im + tmp[2].im; > - > #ifdef TX_INT32 > + out[0*stride].re = (int64_t)tmp[0].re + tmp[2].re; > + out[0*stride].im = (int64_t)tmp[0].im + tmp[2].im; > mtmp[0] = (int64_t)tab[ 8] * tmp[1].re; > mtmp[1] = (int64_t)tab[ 9] * tmp[1].im; > mtmp[2] = (int64_t)tab[10] * tmp[2].re; > @@ -198,6 +197,8 @@ static av_always_inline void fft3(TXComplex *out, TXComplex *in, > out[2*stride].re = tmp[0].re - (mtmp[2] - mtmp[0] + 0x40000000 >> 31); > out[2*stride].im = tmp[0].im - (mtmp[3] + mtmp[1] + 0x40000000 >> 31); > #else > + out[0*stride].re = tmp[0].re + tmp[2].re; > + out[0*stride].im = tmp[0].im + tmp[2].im; > tmp[1].re = tab[ 8] * tmp[1].re; > tmp[1].im = tab[ 9] * tmp[1].im; > tmp[2].re = tab[10] * tmp[2].re; > lgtm _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".