From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 5/6] avutil/tx_template: fix integer ovberflwo in fft3()
Date: Sun, 22 Oct 2023 03:55:47 +0200 (CEST)
Message-ID: <NhK560o--3-9@lynne.ee> (raw)
In-Reply-To: <20231022003520.17154-5-michael@niedermayer.cc>
Oct 22, 2023, 02:36 by michael@niedermayer.cc:
> Fixes: signed integer overflow: -1028966111 + -1314089526 cannot be represented in type 'int'
> Fixes: 63174/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5853273711837184
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavutil/tx_template.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c
> index 8dc3d2519c1..a2c27465cbc 100644
> --- a/libavutil/tx_template.c
> +++ b/libavutil/tx_template.c
> @@ -185,10 +185,9 @@ static av_always_inline void fft3(TXComplex *out, TXComplex *in,
> BF(tmp[1].re, tmp[2].im, in[1].im, in[2].im);
> BF(tmp[1].im, tmp[2].re, in[1].re, in[2].re);
>
> - out[0*stride].re = tmp[0].re + tmp[2].re;
> - out[0*stride].im = tmp[0].im + tmp[2].im;
> -
> #ifdef TX_INT32
> + out[0*stride].re = (int64_t)tmp[0].re + tmp[2].re;
> + out[0*stride].im = (int64_t)tmp[0].im + tmp[2].im;
> mtmp[0] = (int64_t)tab[ 8] * tmp[1].re;
> mtmp[1] = (int64_t)tab[ 9] * tmp[1].im;
> mtmp[2] = (int64_t)tab[10] * tmp[2].re;
> @@ -198,6 +197,8 @@ static av_always_inline void fft3(TXComplex *out, TXComplex *in,
> out[2*stride].re = tmp[0].re - (mtmp[2] - mtmp[0] + 0x40000000 >> 31);
> out[2*stride].im = tmp[0].im - (mtmp[3] + mtmp[1] + 0x40000000 >> 31);
> #else
> + out[0*stride].re = tmp[0].re + tmp[2].re;
> + out[0*stride].im = tmp[0].im + tmp[2].im;
> tmp[1].re = tab[ 8] * tmp[1].re;
> tmp[1].im = tab[ 9] * tmp[1].im;
> tmp[2].re = tab[10] * tmp[2].re;
>
lgtm
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-22 1:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 0:35 [FFmpeg-devel] [PATCH 1/6] avformat/mov: Check that is_still_picture_avif has no trak based streams Michael Niedermayer
2023-10-22 0:35 ` [FFmpeg-devel] [PATCH 2/6] avcodec/cbs: Do not assert on traces beyond 255 bits Michael Niedermayer
2023-10-22 14:34 ` Mark Thompson
2023-10-23 20:53 ` Michael Niedermayer
2023-10-23 21:36 ` Mark Thompson
2023-10-22 0:35 ` [FFmpeg-devel] [PATCH 3/6] avcodec/apedec: Fix integer overflow in predictor_decode_stereo_3950() Michael Niedermayer
2023-10-22 0:35 ` [FFmpeg-devel] [PATCH 4/6] avcodec/dovi_rpu: Use 64 bit in get_us/se_coeff() Michael Niedermayer
2023-10-22 0:35 ` [FFmpeg-devel] [PATCH 5/6] avutil/tx_template: fix integer ovberflwo in fft3() Michael Niedermayer
2023-10-22 1:55 ` Lynne [this message]
2023-10-23 20:44 ` Michael Niedermayer
2023-10-22 0:35 ` [FFmpeg-devel] [PATCH 6/6] tools/target_dec_fuzzer: Adjust threshold for CSCD Michael Niedermayer
2023-10-31 22:13 ` [FFmpeg-devel] [PATCH 1/6] avformat/mov: Check that is_still_picture_avif has no trak based streams Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NhK560o--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git