* [FFmpeg-devel] [PATCH] configure: disable libglslang/libshaderc if the vulkan is disabled
@ 2023-10-14 16:38 Lynne
2023-10-15 13:47 ` Tristan Matthews
0 siblings, 1 reply; 3+ messages in thread
From: Lynne @ 2023-10-14 16:38 UTC (permalink / raw)
To: Ffmpeg Devel
[-- Attachment #1: Type: text/plain, Size: 117 bytes --]
Fixes build failures when the Vulkan headers are too old and libglslang
or libshaderc are enabled.
Patch attached.
[-- Attachment #2: 0001-configure-disable-libglslang-libshaderc-if-the-vulka.patch --]
[-- Type: text/x-diff, Size: 866 bytes --]
From b47d5d3759f9c3de15846ae0fa184f1fa93f2c9a Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Sat, 14 Oct 2023 18:36:46 +0200
Subject: [PATCH] configure: disable libglslang/libshaderc if the vulkan is
disabled
Fixes build failures when the Vulkan headers are too old and libglslang
or libshaderc are enabled.
---
configure | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/configure b/configure
index fc7263bf59..582525db30 100755
--- a/configure
+++ b/configure
@@ -7155,6 +7155,10 @@ if enabled vulkan; then
check_cpp_condition vulkan "vulkan/vulkan.h" "defined(VK_VERSION_1_4) || (defined(VK_VERSION_1_3) && VK_HEADER_VERSION >= 255)"
fi
+if disabled vulkan; then
+ disable libglslang libshaderc spirv_compiler
+fi
+
if enabled x86; then
case $target_os in
mingw32*|mingw64*|win32|win64|linux|cygwin*)
--
2.42.0
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] configure: disable libglslang/libshaderc if the vulkan is disabled
2023-10-14 16:38 [FFmpeg-devel] [PATCH] configure: disable libglslang/libshaderc if the vulkan is disabled Lynne
@ 2023-10-15 13:47 ` Tristan Matthews
2023-10-15 15:12 ` Lynne
0 siblings, 1 reply; 3+ messages in thread
From: Tristan Matthews @ 2023-10-15 13:47 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sat, Oct 14, 2023 at 12:38 PM Lynne <dev@lynne.ee> wrote:
>
> Fixes build failures when the Vulkan headers are too old and libglslang
> or libshaderc are enabled.
This fixes https://trac.ffmpeg.org/ticket/10596
Tested-by: Tristan Matthews <tmatth@videolan.org>
>
> Patch attached.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] configure: disable libglslang/libshaderc if the vulkan is disabled
2023-10-15 13:47 ` Tristan Matthews
@ 2023-10-15 15:12 ` Lynne
0 siblings, 0 replies; 3+ messages in thread
From: Lynne @ 2023-10-15 15:12 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Oct 15, 2023, 15:47 by tmatth@videolan.org:
> On Sat, Oct 14, 2023 at 12:38 PM Lynne <dev@lynne.ee> wrote:
>
>>
>> Fixes build failures when the Vulkan headers are too old and libglslang
>> or libshaderc are enabled.
>>
>
> This fixes https://trac.ffmpeg.org/ticket/10596
>
> Tested-by: Tristan Matthews <tmatth@videolan.org>
>
Thanks, pushed
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-15 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-14 16:38 [FFmpeg-devel] [PATCH] configure: disable libglslang/libshaderc if the vulkan is disabled Lynne
2023-10-15 13:47 ` Tristan Matthews
2023-10-15 15:12 ` Lynne
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git