From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3AABC47B26 for ; Mon, 2 Oct 2023 12:31:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D8DA68CD7E; Mon, 2 Oct 2023 15:31:03 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AD8EF68CC41 for ; Mon, 2 Oct 2023 15:30:57 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 8657810602DC for ; Mon, 2 Oct 2023 12:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1696249856; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=qHVbdQbbAeTvXnxKtLOqYBhW23gBO82iboA8TIxpp80=; b=FABfeir4tcozYhcaS0Qb/cEfe9Liu70xbKkcjSPoNnB/wa5IQ1oFpDSA9ov0pAvw NS+8CUtgRShD1ZZk/CaiIiiD1++u9szVj1grrW/q0TbP98NlYDrYjepEqe3XQDOeKEf BZtzgSjys0di6RJMelylZEax4e/39nHMlALfFEM+Si+tif5uA+yL6I1YVqTXtloImhQ sA7Yht/3Qcnd+uGwdzRbJTnMeokizEq5vKhXz6Lqnc0oBTHCdX6KhPlSlQ+QYU7t5lD XUrAZMatuv0cVrbOhKuhNz3mOwdfFaRJjmq0s8idtyyZewm+FcaOnHyH6Rr7f6mpMY2 dkC97lbbHg== Date: Mon, 2 Oct 2023 14:30:56 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 12/42] avcodec/decode: Use RefStruct API for hwaccel_picture_private X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Sep 19, 2023, 21:58 by andreas.rheinhardt@outlook.com: > Avoids allocations and therefore error checks: Syncing > hwaccel_picture_private across threads can't fail any more. > Also gets rid of an unnecessary pointer in structures and > in the parameter list of ff_hwaccel_frame_priv_alloc(). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/av1dec.c | 15 ++++----------- > libavcodec/av1dec.h | 4 +--- > libavcodec/decode.c | 28 ++++++---------------------- > libavcodec/decode.h | 10 +++------- > libavcodec/h264_picture.c | 19 +++++-------------- > libavcodec/h264_slice.c | 3 +-- > libavcodec/h264dec.h | 1 - > libavcodec/hevc_refs.c | 7 +++---- > libavcodec/hevcdec.c | 11 ++--------- > libavcodec/hevcdec.h | 3 +-- > libavcodec/hwaccel_internal.h | 3 ++- > libavcodec/mpegpicture.c | 18 +++++------------- > libavcodec/mpegpicture.h | 1 - > libavcodec/vp8.c | 14 ++++---------- > libavcodec/vp8.h | 4 +--- > libavcodec/vp9.c | 15 +++++---------- > libavcodec/vp9shared.h | 3 +-- > libavcodec/vulkan_av1.c | 9 +++------ > libavcodec/vulkan_h264.c | 9 +++------ > libavcodec/vulkan_hevc.c | 9 +++------ > 20 files changed, 53 insertions(+), 133 deletions(-) > Patchhset works and tests fine. I've reviewed the code in this patch. Looks good, and it reduces a constant per-frame free/alloc. Thanks _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".