From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 45D624632C for ; Fri, 15 Sep 2023 00:06:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EEDBA68C824; Fri, 15 Sep 2023 03:06:00 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9825768C2DC for ; Fri, 15 Sep 2023 03:05:54 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 3FB7410601FD for ; Fri, 15 Sep 2023 00:05:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1694736354; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=PwTDMWx3hwwPuyJ07TWjxwtkcfkPPfuhhWJKoLQcNUo=; b=Jw4xnpKUA+c8hsbp8pzLw3s+4DA0nV75BValkF105xAnomCdW+l+7sHiuk9sWuhH mj8/ogVG2HqJ3WKjUK3XlzsNMBwkGlGhQQSWMqc5xH6m2mcsu8h6ffTUnhfRWJxPS0b Li0icNJfMJxjQE8Q+DuO+SDh2WlGtHScU/b/8D+joyDVI/yZ5OMRMXDSygt8gCSK5rQ euUlYu2cTLGy0Un4zWFQNgNdc3QVrnMPntjK5u6HYy73PUrT8o1DRezI57xxoytypBx ezXzaL3bFwBs15L9H25p1g5UX8QRiScJZw1KEe+cgk2pQOdG3eAFSWJtk0s0IREGO33 OjjlYF1QSw== Date: Fri, 15 Sep 2023 02:05:54 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vulkan_decode: Factor creating session params out, fix leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Sep 15, 2023, 01:45 by andreas.rheinhardt@outlook.com: > All Vulkan HWAccels share the same boilerplate code for creating > session params and this includes a common bug: In case actually > creating the video session parameters fails, the buffer destined > to hold them leaks; in case of HEVC this is also true if > get_data_set_buf() fails. > > This commit factors this code out and fixes the leak. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vulkan_av1.c | 28 ++++------------------------ > libavcodec/vulkan_decode.c | 31 ++++++++++++++++++++++++++++++- > libavcodec/vulkan_decode.h | 5 +++-- > libavcodec/vulkan_h264.c | 28 ++++------------------------ > libavcodec/vulkan_hevc.c | 27 +++------------------------ > 5 files changed, 44 insertions(+), 75 deletions(-) > Patchset tested and reviewed, LGTM. Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".