From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vulkan_decode: Factor creating session params out, fix leak
Date: Fri, 15 Sep 2023 02:05:54 +0200 (CEST)
Message-ID: <NeL97eo--3-9@lynne.ee> (raw)
In-Reply-To: <GV1P250MB0737BD44A94683CD74809A6C8FF7A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Sep 15, 2023, 01:45 by andreas.rheinhardt@outlook.com:
> All Vulkan HWAccels share the same boilerplate code for creating
> session params and this includes a common bug: In case actually
> creating the video session parameters fails, the buffer destined
> to hold them leaks; in case of HEVC this is also true if
> get_data_set_buf() fails.
>
> This commit factors this code out and fixes the leak.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/vulkan_av1.c | 28 ++++------------------------
> libavcodec/vulkan_decode.c | 31 ++++++++++++++++++++++++++++++-
> libavcodec/vulkan_decode.h | 5 +++--
> libavcodec/vulkan_h264.c | 28 ++++------------------------
> libavcodec/vulkan_hevc.c | 27 +++------------------------
> 5 files changed, 44 insertions(+), 75 deletions(-)
>
Patchset tested and reviewed, LGTM.
Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-09-15 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 23:44 [FFmpeg-devel] [PATCH 1/5] avutil/hwcontext_vulkan: Remove redundant resetting Andreas Rheinhardt
2023-09-14 23:45 ` [FFmpeg-devel] [PATCH 2/5] avutil/hwcontext_vulkan: Improve type-safety Andreas Rheinhardt
2023-09-14 23:45 ` [FFmpeg-devel] [PATCH 3/5] avutil/hwcontext_vulkan: Deduplicate code Andreas Rheinhardt
2023-09-14 23:45 ` [FFmpeg-devel] [PATCH 4/5] avutil/hwcontext_vulkan: Cosmetics Andreas Rheinhardt
2023-09-14 23:45 ` [FFmpeg-devel] [PATCH 5/5] avcodec/vulkan_decode: Factor creating session params out, fix leak Andreas Rheinhardt
2023-09-15 0:05 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NeL97eo--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git