From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0B8C846144 for ; Sun, 6 Aug 2023 17:35:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E8A4468C629; Sun, 6 Aug 2023 20:35:41 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 021C468BBC9 for ; Sun, 6 Aug 2023 20:35:35 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 9FFC3106015D for ; Sun, 6 Aug 2023 17:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691343335; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=I390RpVdQSoYA3AaXMHdByPnmrkCp3rP3MA5PERFDIE=; b=xQeg8qAB8CvIM/4MuCYcWDzt8HHbFaXpFUqYF6OkMSDlq0rATJs2dj4Pnq0Zj8gw f719zTE4OXjwzjO6LsCfs+1OUOf/xzzNre2VoD8Pxx7heM0Cj+GVTXKqEHOHyN4zOgz S+hJNcI0MYLeDnzPfiAo9R6JpcHx69sgwTlBVTe3KXIXZujbABMrFq2c3Xn/KWgXFlc QFIoffrrU6RmDG+o7XpWV3chwiKH/T9BGDESY6owZxKx0x0UZBaVZiuGdHax+1d+B8H GHQtYPccFaySwKD2tW7G83k/wAhdBXIbM3iSDKJGnJ55pEzDmtEySfjM8c+MmLmBiWe XYJd/tz7WQ== Date: Sun, 6 Aug 2023 19:35:35 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20230806124202.7833-1-cus@passwd.hu> References: <20230806124202.7833-1-cus@passwd.hu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/on2avc: use correct fft sizes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Aug 6, 2023, 14:42 by cus@passwd.hu: > With the earlier patch this fixes the audio corruption regression caused by > 6ba0aa1770ba29eb4126c6a706f6b0cd3809648f. > > Fixes ticket #10029. > > Signed-off-by: Marton Balint > --- > libavcodec/on2avc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/on2avc.c b/libavcodec/on2avc.c > index 474adb149d..0d0869bc9c 100644 > --- a/libavcodec/on2avc.c > +++ b/libavcodec/on2avc.c > @@ -956,13 +956,13 @@ static av_cold int on2avc_decode_init(AVCodecContext *avctx) > if ((ret = av_tx_init(&c->mdct_small, &c->mdct_small_fn, AV_TX_FLOAT_MDCT, 1, 128, &scale, 0)) < 0) > return ret; > > - if ((ret = av_tx_init(&c->fft1024, &c->fft1024_fn, AV_TX_FLOAT_FFT, 1, 1024, NULL, 0)) < 0) > + if ((ret = av_tx_init(&c->fft1024, &c->fft1024_fn, AV_TX_FLOAT_FFT, 1, 512, NULL, 0)) < 0) > return ret; > - if ((ret = av_tx_init(&c->fft512, &c->fft512_fn, AV_TX_FLOAT_FFT, 1, 512, NULL, 0)) < 0) > + if ((ret = av_tx_init(&c->fft512, &c->fft512_fn, AV_TX_FLOAT_FFT, 1, 256, NULL, 0)) < 0) > return ret; > - if ((ret = av_tx_init(&c->fft256, &c->fft256_fn, AV_TX_FLOAT_FFT, 0, 256, NULL, 0)) < 0) > + if ((ret = av_tx_init(&c->fft256, &c->fft256_fn, AV_TX_FLOAT_FFT, 0, 128, NULL, 0)) < 0) > return ret; > - if ((ret = av_tx_init(&c->fft128, &c->fft128_fn, AV_TX_FLOAT_FFT, 0, 128, NULL, 0)) < 0) > + if ((ret = av_tx_init(&c->fft128, &c->fft128_fn, AV_TX_FLOAT_FFT, 0, 64, NULL, 0)) < 0) > return ret; > > c->fdsp = avpriv_float_dsp_alloc(avctx->flags & AV_CODEC_FLAG_BITEXACT); > -- > 2.35.3 > Could you rename the contexts and functions so they're not misleading? Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".