From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 3/3] avfft: wrap lavu/tx instead of ff_rdft
Date: Wed, 26 Jul 2023 09:30:56 +0200 (CEST)
Message-ID: <NaG5uYW--3-9@lynne.ee> (raw)
In-Reply-To: <NaG5X1Z--3-9@lynne.ee-NaG5_-0----9>
[-- Attachment #1: Type: text/plain, Size: 17 bytes --]
Patch attached.
[-- Attachment #2: 0003-avfft-wrap-lavu-tx-instead-of-ff_rdft.patch --]
[-- Type: text/x-diff, Size: 1888 bytes --]
From 68781f3bc021fe96c4b4b4a355e03d7c5bd3539b Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Thu, 10 Nov 2022 11:26:59 +0100
Subject: [PATCH 3/3] avfft: wrap lavu/tx instead of ff_rdft
---
libavcodec/avfft.c | 37 ++++++++++++++++++++++++-------------
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/libavcodec/avfft.c b/libavcodec/avfft.c
index ff5c739897..f5880f9932 100644
--- a/libavcodec/avfft.c
+++ b/libavcodec/avfft.c
@@ -125,33 +125,44 @@ av_cold void av_mdct_end(FFTContext *s)
av_fft_end(s);
}
-#if CONFIG_RDFT
-
RDFTContext *av_rdft_init(int nbits, enum RDFTransformType trans)
{
- RDFTContext *s = av_malloc(sizeof(*s));
+ int ret;
+ float scale = 1.0f;
+ AVTXWrapper *s;
- if (s && ff_rdft_init(s, nbits, trans))
- av_freep(&s);
+ /* The other 2 modes are unconventional, do not form an orthogonal
+ * transform, have never been useful, and so they're not implemented. */
+ if (trans != IDFT_C2R && trans != DFT_R2C)
+ return NULL;
- return s;
+ s = av_malloc(sizeof(*s));
+ if (!s)
+ return NULL;
+
+ ret = av_tx_init(&s->ctx, &s->fn, AV_TX_FLOAT_RDFT, trans == IDFT_C2R,
+ 1 << nbits, &scale, AV_TX_INPLACE);
+ if (ret < 0) {
+ av_free(s);
+ return NULL;
+ }
+
+ s->stride = (trans == DFT_C2R) ? sizeof(float) : sizeof(AVComplexFloat);
+
+ return (RDFTContext *)s;
}
void av_rdft_calc(RDFTContext *s, FFTSample *data)
{
- s->rdft_calc(s, data);
+ AVTXWrapper *w = (AVTXWrapper *)s;
+ w->fn(w->ctx, data, (void *)data, w->stride);
}
av_cold void av_rdft_end(RDFTContext *s)
{
- if (s) {
- ff_rdft_end(s);
- av_free(s);
- }
+ av_fft_end((FFTContext *)s);
}
-#endif /* CONFIG_RDFT */
-
#if CONFIG_DCT
DCTContext *av_dct_init(int nbits, enum DCTTransformType inverse)
--
2.40.1
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-07-26 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 7:29 [FFmpeg-devel] [PATCH 1/3] avfft: wrap lavu/tx instead of ff_fft Lynne
[not found] ` <NaG5X1Z--3-9@lynne.ee-NaG5_-0----9>
2023-07-26 7:30 ` [FFmpeg-devel] [PATCH 2/3] avfft: wrap lavu/tx instead of ff_mdct Lynne
2023-07-26 7:30 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NaG5uYW--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git