Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne <dev@lynne.ee>
To: Ffmpeg Devel <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 1/2] lavu/tx: disable odd-length RDFTs
Date: Tue, 25 Jul 2023 11:41:30 +0200 (CEST)
Message-ID: <NaBQCTh--3-9@lynne.ee> (raw)

[-- Attachment #1: Type: text/plain, Size: 120 bytes --]

They're presently broken, and not really needed anywhere.
They can be fixed at a later date, but for 

Patch attached.


[-- Attachment #2: 0001-lavu-tx-disable-odd-length-RDFTs.patch --]
[-- Type: text/x-diff, Size: 1355 bytes --]

From 01925c08bcd2073770c0c627fc64232a7593a321 Mon Sep 17 00:00:00 2001
From: Lynne <dev@lynne.ee>
Date: Tue, 25 Jul 2023 11:01:41 +0200
Subject: [PATCH 1/2] lavu/tx: disable odd-length RDFTs

They're presently broken.
---
 libavutil/tx_template.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c
index c4ec9502e0..a4040454db 100644
--- a/libavutil/tx_template.c
+++ b/libavutil/tx_template.c
@@ -1709,8 +1709,8 @@ static const FFTXCodelet TX_NAME(ff_tx_rdft_r2c_def) = {
     .type       = TX_TYPE(RDFT),
     .flags      = AV_TX_UNALIGNED | AV_TX_INPLACE |
                   FF_TX_OUT_OF_PLACE | FF_TX_FORWARD_ONLY,
-    .factors    = { 2, TX_FACTOR_ANY },
-    .nb_factors = 2,
+    .factors[0] = 2,
+    .nb_factors = 1,
     .min_len    = 2,
     .max_len    = TX_LEN_UNLIMITED,
     .init       = TX_NAME(ff_tx_rdft_init),
@@ -1724,8 +1724,8 @@ static const FFTXCodelet TX_NAME(ff_tx_rdft_c2r_def) = {
     .type       = TX_TYPE(RDFT),
     .flags      = AV_TX_UNALIGNED | AV_TX_INPLACE |
                   FF_TX_OUT_OF_PLACE | FF_TX_INVERSE_ONLY,
-    .factors    = { 2, TX_FACTOR_ANY },
-    .nb_factors = 2,
+    .factors[0] = 2,
+    .nb_factors = 1,
     .min_len    = 2,
     .max_len    = TX_LEN_UNLIMITED,
     .init       = TX_NAME(ff_tx_rdft_init),
-- 
2.40.1


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2023-07-25  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25  9:41 Lynne [this message]
     [not found] ` <NaBQCTh--3-9@lynne.ee-NaBQFrM----9>
2023-07-25  9:43   ` [FFmpeg-devel] [PATCH 2/2] lavu/tx: add a half-complex R2C transform Lynne
2023-07-27  9:59   ` [FFmpeg-devel] [PATCH 1/2] lavu/tx: disable odd-length RDFTs Lynne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=NaBQCTh--3-9@lynne.ee \
    --to=dev@lynne.ee \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git