From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 8D32B4632C
	for <ffmpegdev@gitmailbox.com>; Sat, 15 Jul 2023 08:06:02 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 83F1868C301;
	Sat, 15 Jul 2023 11:05:59 +0300 (EEST)
Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6755A68BF90
 for <ffmpeg-devel@ffmpeg.org>; Sat, 15 Jul 2023 11:05:52 +0300 (EEST)
Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10])
 by w4.tutanota.de (Postfix) with ESMTP id 4EC3410600DF
 for <ffmpeg-devel@ffmpeg.org>; Sat, 15 Jul 2023 08:05:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1689408351; 
 s=s1; d=lynne.ee;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=1E01tMWXi8nqdJUzE5r4WgsNLBAdt641jsHKwY13Fm8=;
 b=FgcbkX3QFJfztmDjTLGaal9DOPViM17z6dMjVbohvI7azYZEPqKMTvbBikunWd7g
 9fX2qwqXdbFBXtu3bHLv0vx6c8AJW4UpbVlCdqnCPMRmMVYamD7EhCDXqAPZUJElP5X
 la9YTOfjEyP4xqh8Za8ShLYHcpkShzvRo/qX3169/JLKLStRGeKFvMQfasQy0qkA2l/
 J1jTRkOXxZqY+R928UWY4l8EWkWaO00IeB+ltmXJf6ablR4Fxc7hzkO91j1y5JVHMDV
 8XWVuMOhZEOqUx4tLMcBODJkV+r8K1n8JAf4+8uP/Q55uptVMSc9sbAyHXzhdIst/4d
 iPuq7AowUA==
Date: Sat, 15 Jul 2023 10:05:51 +0200 (CEST)
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <N_N_Pj5--3-9@lynne.ee>
In-Reply-To: <20230714182835.66326-4-remi@remlab.net>
References: <12243004.O9o76ZdvQC@basile.remlab.net>
 <20230714182835.66326-4-remi@remlab.net>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 4/7] checkasm: use pointers for
 start/stop functions
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/N_N_Pj5--3-9@lynne.ee/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Jul 14, 2023, 20:29 by remi@remlab.net:

> This makes all calls to the bench start and stop functions via
> function pointers. While the primary goal is to support run-time
> selection of the performance measurement back-end in later commits,
> this has the side benefit of containing platform dependencies in to
> checkasm.c and out of checkasm.h.
> ---
>  tests/checkasm/checkasm.c | 33 ++++++++++++++++++++++++++++-----
>  tests/checkasm/checkasm.h | 31 ++++---------------------------
>  2 files changed, 32 insertions(+), 32 deletions(-)
>

Not sure I agree with this commit, the overhead can be detectable,
and we have a lot of small functions with runtime a few times that
of a null function call.
Can you store the function pointers out of the loop to reduce
the derefs needed?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".