From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E24846AB2 for ; Sun, 2 Jul 2023 18:58:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D008A68C461; Sun, 2 Jul 2023 21:58:12 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 72EB668B838 for ; Sun, 2 Jul 2023 21:58:06 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 3248D106019A for ; Sun, 2 Jul 2023 18:58:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1688324286; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=XempjMqKftWMg3TYQ0iZtUW0mamKeT+DYKPkbix6v8I=; b=RZTyZzby5xYeUa1L2w5HPYXcUr6MUamC66urgQ6X04O+x/v4FI6rc0y/Wqg0+mYx RmHHC1WMDmmJ7UGVvlWbLhzSvEn3dL6OYcNmx6aMOy2drA7aBwts98opVCRBw4RsjgN ZV1865klE7WXsOokY0QX3WeZAG7cORsVmZqclcCaKUTJ8s2J93HCWlz7wlbMZMq7mEg nwD5jg60xdcp5eLxxtYdFxehlSGPDBoOj+4JdZTG0Je2VYu5KnXZqEs1an8AVpRJf+h 4En1Tn5N3rF93hjclcAkqI82cgwmCo3i3CZlGwu+UWSjfeazW2TnyX0Apy4z0scDtwn IIgDQrfTLw== Date: Sun, 2 Jul 2023 20:58:06 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jul 2, 2023, 20:41 by tmundt75@gmail.com: > Am So., 2. Juli 2023 um 18:57 Uhr schrieb Lynne : > >> Jul 2, 2023, 18:54 by dev@lynne.ee: >> >> > The issue is that clipping the interpolated temporal sample against >> > the spatially predicted sample causes artifacts to appear. >> > >> > Discovered while writing the Vulkan version (where I omitted the >> > same check). >> > >> > The clipping in the code is carried over from yadif. Removing the >> > same code in yadif does not make any difference to the output. >> > I think that the check was simply ill-adapted to the new prediction >> > code and does more harm. >> > >> > I tested replacing the range clip with only an FFMAX, and only an >> > FFMIN, but in both cases, artifacts still appeared. >> > >> > Test sample 1: >> https://files.lynne.ee/testsamples/mbaff_1080i60_idx.mkvTest sample 2: >> https://files.lynne.ee/testsamples/mbaff_bdmv_1080i60_8slice.mkv >> > >> > Command line: >> > ./ffmpeg_g -cpuflags 0 -i -vf bwdif=mode=send_field -c:v >> rawvideo -y .nut >> > Make sure to disable the assembly. >> > >> > Comparisons: >> > https://files.lynne.ee/bwdif_01_before.png >> > https://files.lynne.ee/bwdif_01_after.png >> > Generated from sample 1 via: >> > ffmpeg -ss 00:00:00.184 -i .nut -vf >> crop=w=420:h=240:x=700:y=300,scale=iw*2:ih*2 -y .png >> > >> > https://files.lynne.ee/bwdif_02_before.png >> > https://files.lynne.ee/bwdif_02_after.pngffmpeg -ss 00:00:00.417 -i >> .nut -vf crop=w=420:h=240:x=1100:y=200,scale=iw*2:ih*2 -y >> .png >> > >> >> Corrected links for the second sample: >> >> https://files.lynne.ee/bwdif_02_before.png >> https://files.lynne.ee/bwdif_02_after.png >> ffmpeg -ss 00:00:00.417 -i .nut -vf >> crop=w=420:h=240:x=1100:y=200,scale=iw*2:ih*2 -y .png >> >> I'm sure I hit a newline. The artifacts are a lot more noticeable in the >> second sample. >> > > I developed the bwdif to achieve the best possible balance between speed > and quality of all different image contents from the broadcast point of > view. This includes moving video as well as moving and static graphic > elements. Unfortunately, the improvement of one image content often leads > to the degradation of another. The code you removed fundamentally > stabilizes the static graphic elements. This outweighs the slightly more > frequent artifacts in moving video considering the general purpose of the > filter. > Could you post examples? I've been unable to find any that look worse with the patch. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".