Re: [FFmpeg-devel] [PATCH v2 06/15] avfilter/vf_bwdif: Add clip and spatial macros for aarch64 neon

[Lynne <dev@lynne.ee>]

Jul 2, 2023, 14:34 by jc@kynesim.co.uk:

> Signed-off-by: John Cox <jc@kynesim.co.uk>
> ---
>  libavfilter/aarch64/vf_bwdif_neon.S | 73 +++++++++++++++++++++++++++++
>  1 file changed, 73 insertions(+)
>
> diff --git a/libavfilter/aarch64/vf_bwdif_neon.S b/libavfilter/aarch64/vf_bwdif_neon.S
> index 6a614f8d6e..48dc7bcd9d 100644
> --- a/libavfilter/aarch64/vf_bwdif_neon.S
> +++ b/libavfilter/aarch64/vf_bwdif_neon.S
> @@ -66,6 +66,79 @@
>  umlsl2          \a3\().4s, \s1\().8h, \k
>  .endm
>  
> +//      int b = m2s1 - m1;
> +//      int f = p2s1 - p1;
> +//      int dc = c0s1 - m1;
> +//      int de = c0s1 - p1;
> +//      int sp_max = FFMIN(p1 - c0s1, m1 - c0s1);
> +//      sp_max = FFMIN(sp_max, FFMAX(-b,-f));
> +//      int sp_min = FFMIN(c0s1 - p1, c0s1 - m1);
> +//      sp_min = FFMIN(sp_min, FFMAX(b,f));
> +//      diff = diff == 0 ? 0 : FFMAX3(diff, sp_min, sp_max);
> +.macro SPAT_CHECK diff, m2s1, m1, c0s1, p1, p2s1, t0, t1, t2, t3
> +        uqsub           \t0\().16b, \p1\().16b, \c0s1\().16b
> +        uqsub           \t2\().16b, \m1\().16b, \c0s1\().16b
> +        umin            \t2\().16b, \t0\().16b, \t2\().16b
> +
> +        uqsub           \t1\().16b, \m1\().16b, \m2s1\().16b
> +        uqsub           \t3\().16b, \p1\().16b, \p2s1\().16b
> +        umax            \t3\().16b, \t3\().16b, \t1\().16b
> +        umin            \t3\().16b, \t3\().16b, \t2\().16b
> +
> +        uqsub           \t0\().16b, \c0s1\().16b, \p1\().16b
> +        uqsub           \t2\().16b, \c0s1\().16b, \m1\().16b
> +        umin            \t2\().16b, \t0\().16b, \t2\().16b
> +
> +        uqsub           \t1\().16b, \m2s1\().16b, \m1\().16b
> +        uqsub           \t0\().16b, \p2s1\().16b, \p1\().16b
> +        umax            \t0\().16b, \t0\().16b, \t1\().16b
> +        umin            \t2\().16b, \t2\().16b, \t0\().16b
> +
> +        cmeq            \t1\().16b, \diff\().16b, #0
> +        umax            \diff\().16b, \diff\().16b, \t3\().16b
> +        umax            \diff\().16b, \diff\().16b, \t2\().16b
> +        bic             \diff\().16b, \diff\().16b, \t1\().16b
> +.endm
> +
> +//      i0 = s0;
> +//      if (i0 > d0 + diff0)
> +//          i0 = d0 + diff0;
> +//      else if (i0 < d0 - diff0)
> +//          i0 = d0 - diff0;
> +//
> +// i0 = s0 is safe
> +.macro DIFF_CLIP i0, s0, d0, diff, t0, t1
> +        uqadd           \t0\().16b, \d0\().16b, \diff\().16b
> +        uqsub           \t1\().16b, \d0\().16b, \diff\().16b
> +        umin            \i0\().16b, \s0\().16b, \t0\().16b
> +        umax            \i0\().16b, \i0\().16b, \t1\().16b
> +.endm
> +
> +//      i0 = FFABS(m1 - p1) > td0 ? i1 : i2;
> +//      DIFF_CLIP
> +//
> +// i0 = i1 is safe
> +.macro INTERPOL i0, i1, i2, m1, d0, p1, td0, diff, t0, t1, t2
> +        uabd            \t0\().16b, \m1\().16b, \p1\().16b
> +        cmhi            \t0\().16b, \t0\().16b, \td0\().16b
> +        bsl             \t0\().16b, \i1\().16b, \i2\().16b
> +        DIFF_CLIP       \i0, \t0, \d0, \diff, \t1, \t2
> +.endm
> +
> +.macro PUSH_VREGS
> +        stp             d8,  d9,  [sp, #-64]!
> +        stp             d10, d11, [sp, #16]
> +        stp             d12, d13, [sp, #32]
> +        stp             d14, d15, [sp, #48]
> +.endm
> +
> +.macro POP_VREGS
> +        ldp             d14, d15, [sp, #48]
> +        ldp             d12, d13, [sp, #32]
> +        ldp             d10, d11, [sp, #16]
> +        ldp             d8,  d9,  [sp], #64
> +.endm
>

Could you squash? Adding empty files and then commit by
commit filling them up is pointless and makes it harder to
review. Just export what you need in one commit, and add
everything else in another.

Also, keep in mind the final spatial clip at the end should be
removable. I discovered it makes the filter look quite a lot
better. Currently, only the Vulkan version does it, but we're
looking into changing the C/asm versions too, and you're the
second one to rush into implementing asm for it before we've
had a chance to discuss it properly.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".