Re: [FFmpeg-devel] [PATCH 04/21 v2] tests/fate: add a test for -streamloop with transcoding video+audio

From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 04/21 v2] tests/fate: add a test for -streamloop with transcoding video+audio
Date: Mon, 19 Jun 2023 17:48:31 +0200 (CEST)
Message-ID: <NYJKye0--B-9@lynne.ee> (raw)
In-Reply-To: <tencent_6DF301A849D3F4537075CEC9082EB8C54105@qq.com>

Jun 19, 2023, 15:40 by quinkblack@foxmail.com:

>> 在 2023年6月19日，21:22，James Almer <jamrial@gmail.com> 写道：
>>
>> On 6/19/2023 9:34 AM, "zhilizhao(赵志立)" wrote:
>>
>>>>> On Jun 19, 2023, at 20:29, James Almer <jamrial@gmail.com> wrote:
>>>>>
>>>>
>>>> On 6/16/2023 3:01 AM, Anton Khirnov wrote:
>>>>
>>>>> ---
>>>>> Now using aacdec_fixed with s32le output
>>>>> ---
>>>>>  tests/fate/ffmpeg.mak                         |   4 +
>>>>>  tests/ref/fate/ffmpeg-streamloop-transcode-av | 151 ++++++++++++++++++
>>>>>  2 files changed, 155 insertions(+)
>>>>>  create mode 100644 tests/ref/fate/ffmpeg-streamloop-transcode-av
>>>>> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
>>>>> index c26c748934..87cd0b46d0 100644
>>>>> --- a/tests/fate/ffmpeg.mak
>>>>> +++ b/tests/fate/ffmpeg.mak
>>>>> @@ -132,6 +132,10 @@ fate-ffmpeg-fix_sub_duration_heartbeat: CMD = fmtstdout srt -fix_sub_duration \
>>>>>  -c:s srt \
>>>>>  -f null -
>>>>>  +FATE_SAMPLES_FFMPEG-$(call FRAMECRC, MATROSKA, H264 AAC_FIXED, PCM_S32LE_ENCODER) += fate-ffmpeg-streamloop-transcode-av
>>>>> +fate-ffmpeg-streamloop-transcode-av: CMD = \
>>>>> + framecrc -auto_conversion_filters -stream_loop 3 -i $(TARGET_SAMPLES)/mkv/1242-small.mkv -c:a pcm_s32le
>>>>>
>>>>
>>>> I think this is missing -c:a ac3_fixed before the -i
>>>>
>>> You mean aac_fixed? I have tried, but the result on two processor don't match neither.
>>>
>>
>> The output will of course be different than what's in the reference file in this patch. What matters is that the new output does match across different CPUs.
>>
>
> Yes I know the idea, what I said is the second case.
>

Could you run the test on a system where it fails with
this diff applied: https://0x0.st/HTOD.diff
Thanks
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".