From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5A8CD45F25 for ; Sun, 18 Jun 2023 21:56:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D8E2268BF2A; Mon, 19 Jun 2023 00:56:02 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98529680BC0 for ; Mon, 19 Jun 2023 00:55:56 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 9B7021060155 for ; Sun, 18 Jun 2023 21:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1687125356; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=i3ZNZdqZ9MMeFof1ylI5ewFu93Lmlp8sQDJrF/CmbKo=; b=u8EI9DhMw+4ZQs2DcIKxex6SAVO1yot+22vgCWlo9zowqQl/XkJM3IoPG6uncmWk y8hewgY9JOGA5KV6syHzJyJtZRFDpUxdCLAd5mpwDXrNZ8A/Bwx5X6yQ5Drv9dHm+73 eQHMSIjxxTYJzQPOntKS9vLL7Ti8YP48vVprP27yaRgFp/VpnRIIY/4++IZyeyRc/g0 SiMaISRisHnAY4dx+CBomz+X/Tbtf5vfyJw8ZS2YlooYawAOS8LIrirwAPc+cZalvQm y1LP0/qsrZHmxLKO/4H9v21fyjxf0oL4gg0eP+4nApnbwpiRNvY9SdYsuQWa7h5YX8a FcYHXmSWgg== Date: Sun, 18 Jun 2023 23:55:56 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: <20230618215021.3044-6-michael@niedermayer.cc> References: <20230618215021.3044-1-michael@niedermayer.cc> <20230618215021.3044-6-michael@niedermayer.cc> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 6/6] doc/developer: Require new modules to include tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jun 18, 2023, 23:50 by michael@niedermayer.cc: > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7da2ce2d5..0c2f2cd7d1 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -805,7 +805,10 @@ Lines with similar content should be aligned vertically when doing so > improves readability. > > @item > -Consider adding a regression test for your code. > +Consider adding a regression test for your code. All new modules > +should be covered by tests. That includes demuxers, muxers, decoders, encoders > +filters, bitstream filters, parsers. If its not possible to do that, add > +an explanation why to your patchset, its ok to not test if theres a reason. > Could you add assembly code to this as well? checkasm is super useful, but is currently lacking quite a few tests. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".