From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/6] doc/developer: Require new modules to include tests
Date: Sun, 18 Jun 2023 23:55:56 +0200 (CEST)
Message-ID: <NYFVTsL--3-9@lynne.ee> (raw)
In-Reply-To: <20230618215021.3044-6-michael@niedermayer.cc>
Jun 18, 2023, 23:50 by michael@niedermayer.cc:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> doc/developer.texi | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/doc/developer.texi b/doc/developer.texi
> index a7da2ce2d5..0c2f2cd7d1 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -805,7 +805,10 @@ Lines with similar content should be aligned vertically when doing so
> improves readability.
>
> @item
> -Consider adding a regression test for your code.
> +Consider adding a regression test for your code. All new modules
> +should be covered by tests. That includes demuxers, muxers, decoders, encoders
> +filters, bitstream filters, parsers. If its not possible to do that, add
> +an explanation why to your patchset, its ok to not test if theres a reason.
>
Could you add assembly code to this as well?
checkasm is super useful, but is currently lacking quite
a few tests.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-18 21:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 21:50 [FFmpeg-devel] [PATCH 1/6] avformat/jpegxl_anim_dec: Perform operations in a different order Michael Niedermayer
2023-06-18 21:50 ` [FFmpeg-devel] [PATCH 2/6] avcodec/utils: fix 2 integer overflows in get_audio_frame_duration() Michael Niedermayer
2023-06-22 23:59 ` Michael Niedermayer
2023-06-18 21:50 ` [FFmpeg-devel] [PATCH 3/6] avformat/jpegxl_anim_dec: add FF_JPEGXL_CONTAINER_SIGNATURE_LE Michael Niedermayer
2023-06-18 22:57 ` Leo Izen
2023-06-19 17:01 ` Michael Niedermayer
2023-06-20 16:50 ` Leo Izen
2023-06-18 21:50 ` [FFmpeg-devel] [PATCH 4/6] avcodec/evc_parse: Check log2_sub_gop_length Michael Niedermayer
2023-06-18 22:27 ` James Almer
2023-06-18 23:01 ` James Almer
2023-06-19 19:03 ` James Almer
2023-06-18 21:50 ` [FFmpeg-devel] [PATCH 5/6] avcodec/vmixdec: Fix several integer anomalies Michael Niedermayer
2023-07-23 18:07 ` Michael Niedermayer
2023-06-18 21:50 ` [FFmpeg-devel] [PATCH 6/6] doc/developer: Require new modules to include tests Michael Niedermayer
2023-06-18 21:55 ` Lynne [this message]
2023-06-19 16:08 ` Anton Khirnov
2023-06-19 9:04 ` Jean-Baptiste Kempf
2023-06-19 16:06 ` Anton Khirnov
2023-06-19 16:09 ` Paul B Mahol
2023-06-21 10:04 ` Anton Khirnov
2023-06-23 23:55 ` Michael Niedermayer
2023-06-18 21:56 ` [FFmpeg-devel] [PATCH 1/6] avformat/jpegxl_anim_dec: Perform operations in a different order Leo Izen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NYFVTsL--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git