From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E73184679E for ; Sun, 18 Jun 2023 10:58:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2553B68BF52; Sun, 18 Jun 2023 13:58:39 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6F94868BB5A for ; Sun, 18 Jun 2023 13:58:33 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 27FCE106014E for ; Sun, 18 Jun 2023 10:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1687085912; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=2ICqmCCAXILC60Zo3EtpeS9sQdXCFgntl8sPxc/vDhQ=; b=y3H4qQ6vD4DfX6kxWbwS2jZvgAYe6qalXhpCVIuoTQYmnZajnS7KpfYNQ7k9Um8/ 05vVN99L9qbDAknyLVpkco2pHnXxTJFHlcUx+Qe3ZxBN39L3nM66Mj1H4Bm71kgsg4V 50dtoXfpOaBxmB2b3SMbFhNRTN7yUXsbE4Pr91eQOgDSKzsS11J04uG8Y7SvKpaJ4CQ qHrvO13r6nxFdPPa6ZyZ3/n7SZHMoegrU7zS34AmKLg/fAjtYpCW1PTwrCiUJMtLj5B eQGyGVwvKUTXpO5Oi8NIBLCUfBL1QQ1nZG+Qc/n18NtILLefCZnPhuroWROgg3xLGje Q4ie5DnY0w== Date: Sun, 18 Jun 2023 12:58:32 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jun 16, 2023, 13:02 by dev@lynne.ee: > Jun 13, 2023, 19:18 by dev@lynne.ee: > >> Jun 13, 2023, 18:56 by andreas.rheinhardt@outlook.com: >> >>> Lynne: >>> >>>> + dst->opaque = av_buffer_ref(src->opaque); >>>> + if (!dst->opaque) { >>>> + ret = AVERROR(ENOMEM); >>>> + goto fail; >>>> + } >>>> >>> >>> According to the doxy, opaque can be left unset (and will be given that >>> it is a new field), yet av_buffer_ref(NULL) will crash. We have >>> av_buffer_replace() for something like that. >>> >> >> Fixed. >> > > Ping. > Consider this out of RFC state. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".