From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field
Date: Sun, 18 Jun 2023 12:58:32 +0200 (CEST)
Message-ID: <NYD906W--3-9@lynne.ee> (raw)
In-Reply-To: <NY2rkbx--3-9@lynne.ee-NY2rofi----9>
Jun 16, 2023, 13:02 by dev@lynne.ee:
> Jun 13, 2023, 19:18 by dev@lynne.ee:
>
>> Jun 13, 2023, 18:56 by andreas.rheinhardt@outlook.com:
>>
>>> Lynne:
>>>
>>>> + dst->opaque = av_buffer_ref(src->opaque);
>>>> + if (!dst->opaque) {
>>>> + ret = AVERROR(ENOMEM);
>>>> + goto fail;
>>>> + }
>>>>
>>>
>>> According to the doxy, opaque can be left unset (and will be given that
>>> it is a new field), yet av_buffer_ref(NULL) will crash. We have
>>> av_buffer_replace() for something like that.
>>>
>>
>> Fixed.
>>
>
> Ping.
>
Consider this out of RFC state.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-06-18 10:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 4:18 Lynne
[not found] ` <NXmySQC--3-9@lynne.ee-NXmyWRF----9>
2023-06-13 4:19 ` [FFmpeg-devel] [PATCH 2/5] vulkan_decode: use the " Lynne
2023-06-13 12:28 ` Anton Khirnov
2023-06-13 12:53 ` Lynne
2023-06-18 11:10 ` Anton Khirnov
2023-06-18 12:20 ` Lynne
[not found] ` <NXmyk7P--3-9@lynne.ee-NXmynAe----9>
2023-06-13 4:20 ` [FFmpeg-devel] [PATCH 3/5] hwcontext_vulkan: call ff_vk_uninit() on device uninit Lynne
[not found] ` <NXmyvDO--3-9@lynne.ee-NXmyy7U----9>
2023-06-13 4:21 ` [FFmpeg-devel] [PATCH 4/5] hwcontext_vulkan: free temporary array once unneeded Lynne
[not found] ` <NXmz5vr-03-9@lynne.ee-NXmz8rg----9>
2023-06-13 4:24 ` [FFmpeg-devel] [PATCH 5/5] vulkan_decode: fix small memory leak Lynne
2023-06-15 20:03 ` [FFmpeg-devel] [PATCH 4/5] hwcontext_vulkan: free temporary array once unneeded Lynne
2023-06-15 20:03 ` [FFmpeg-devel] [PATCH 3/5] hwcontext_vulkan: call ff_vk_uninit() on device uninit Lynne
2023-06-13 4:44 ` [FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field Andreas Rheinhardt
2023-06-13 4:48 ` Lynne
2023-06-13 16:57 ` Andreas Rheinhardt
2023-06-13 17:17 ` Lynne
[not found] ` <NXpkssV--3-9@lynne.ee-NXpkwTT----9>
2023-06-16 11:02 ` Lynne
[not found] ` <NY2rkbx--3-9@lynne.ee-NY2rofi----9>
2023-06-18 10:58 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NYD906W--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git