From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 53C8D46746 for ; Fri, 16 Jun 2023 11:02:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F323468B9FC; Fri, 16 Jun 2023 14:02:41 +0300 (EEST) Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3E37068B103 for ; Fri, 16 Jun 2023 14:02:35 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id EBDD110602DF for ; Fri, 16 Jun 2023 11:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1686913354; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=OevAlgo032szM/aowC0TWZONKn7ryPWDt9Axfmi6ldw=; b=BFbS0YpvvIYAbIj0K/VZlv9KuolGUrKItz1K+CNZIdqR/T09xRHu9HpSF+AUhrdu yPNLd+/3BG4Qhw95Ha1DB/g51Wos9WI1aIDFFOpjvueaYGXwxJGVkRgaukNhUkvz9zT QLgs2Wt/MPLq9B+H/apg0vG/gZ5iNJTe6FZa/pfzoFQGO8fql2ZWU8hZSLZWmWBLWtk jGozmd5WobHdGvkQvvYGk5DkvGe0zi1407ltrGSmC+iLCma/wr4w1eaUOYYP/ziW7ZB WiO86CVGiiy3AhYk05GY9nY7ww6sAr5TELDNEz+bkfDun4FcImNuH3/6UoyLPPdwDXA ou9SUzei+Q== Date: Fri, 16 Jun 2023 13:02:34 +0200 (CEST) From: Lynne To: FFmpeg development discussions and patches Message-ID: In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jun 13, 2023, 19:18 by dev@lynne.ee: > Jun 13, 2023, 18:56 by andreas.rheinhardt@outlook.com: > >> Lynne: >> >>> + dst->opaque = av_buffer_ref(src->opaque); >>> + if (!dst->opaque) { >>> + ret = AVERROR(ENOMEM); >>> + goto fail; >>> + } >>> >> >> According to the doxy, opaque can be left unset (and will be given that >> it is a new field), yet av_buffer_ref(NULL) will crash. We have >> av_buffer_replace() for something like that. >> > > Fixed. > Ping. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".