From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 0AA7346726
	for <ffmpegdev@gitmailbox.com>; Thu, 15 Jun 2023 20:03:30 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BDF068C57C;
	Thu, 15 Jun 2023 23:03:27 +0300 (EEST)
Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4163C6882BA
 for <ffmpeg-devel@ffmpeg.org>; Thu, 15 Jun 2023 23:03:21 +0300 (EEST)
Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10])
 by w4.tutanota.de (Postfix) with ESMTP id 2313F10602DF
 for <ffmpeg-devel@ffmpeg.org>; Thu, 15 Jun 2023 20:03:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1686859400; 
 s=s1; d=lynne.ee;
 h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender;
 bh=ULQT5BWib8wC/WiDbC6AX8BZYW3AIkwHj1i2Y5T/Rds=;
 b=L3cIheZcL4aXzLSyEbrEwWHZstYgfFw+540RSiBqXVj1oEaZnm2tai6g0UktmK4X
 1VI9sTBkBrp07qcu8T/ZXJTljhowzobIqfI6o/oZdWWyNBrILcOBnrzYLDzHTb1QiUl
 QcryYGceUqwT9p068rKCHjMbgwyTUmIqYyxgx6iFjjr7lOZbgf0qvy1cL1MQS0JnsZY
 OiCTHcQD03hEtt531JBYD3T4nEI56WTh/iC6oLGssPnnRaIKlXmyx2x+iXDI78vlwFf
 zHadTsImzv/GKtOG7Sgxqm2SfY9jySUP44GjOKPDyvdNOPDvo8rXs2otdwSPqtCb2v2
 cM66NR9/AQ==
Date: Thu, 15 Jun 2023 22:03:20 +0200 (CEST)
From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <NY-dwGw--3-9@lynne.ee>
In-Reply-To: <168685358957.21886.17411006325784262089@lain.khirnov.net>
References: <NXmWSIQ--3-9@lynne.ee>
 <168685358957.21886.17411006325784262089@lain.khirnov.net>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] pthread_frame: uninit the hwaccel of
 each frame thread
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/NY-dwGw--3-9@lynne.ee/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Jun 15, 2023, 20:26 by anton@khirnov.net:

> Quoting Lynne (2023-06-13 04:11:35)
>
>> The issue is that with a threadsafe hwaccel and multiple enabled
>> frame threads, hwaccel->uninit() is never called.
>> Previously, the function was guaranteed to never have any threads
>> with hwaccel contexts, so it never bothered to uninit it.
>>
>> Patch attached.
>>
>
> Maybe add a note that this only does something for threadsafe hwaccels,
> since otherwise hwaccel state is always cleared here.
>
> Otherwise looks good assuming it was tested with a leak checker.
>

A leak checker is how I actually found this :)
Thanks, added a note and pushed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".