From: Lynne <dev@lynne.ee>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] pthread_frame: uninit the hwaccel of each frame thread
Date: Thu, 15 Jun 2023 22:03:20 +0200 (CEST)
Message-ID: <NY-dwGw--3-9@lynne.ee> (raw)
In-Reply-To: <168685358957.21886.17411006325784262089@lain.khirnov.net>
Jun 15, 2023, 20:26 by anton@khirnov.net:
> Quoting Lynne (2023-06-13 04:11:35)
>
>> The issue is that with a threadsafe hwaccel and multiple enabled
>> frame threads, hwaccel->uninit() is never called.
>> Previously, the function was guaranteed to never have any threads
>> with hwaccel contexts, so it never bothered to uninit it.
>>
>> Patch attached.
>>
>
> Maybe add a note that this only does something for threadsafe hwaccels,
> since otherwise hwaccel state is always cleared here.
>
> Otherwise looks good assuming it was tested with a leak checker.
>
A leak checker is how I actually found this :)
Thanks, added a note and pushed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-06-15 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 2:11 Lynne
[not found] ` <NXmWSIQ--3-9@lynne.ee-NXmWWXY----9>
2023-06-14 16:39 ` Lynne
2023-06-15 18:26 ` Anton Khirnov
2023-06-15 20:03 ` Lynne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NY-dwGw--3-9@lynne.ee \
--to=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git